Hi there,
I read the previous topic before and I believe you believe the issues has been resolved.
However, I have enabled anonymous voting and the anonymous user can vote as many times as they want. I voted 20+ votes.
I am using votingapi-6.x-2.0-rc2.tar.gz and vote_up_down-6.x-1.0-beta2.tar.gz
Also, is it possible to align the vote up/down next to "Read More" or next to "Add Comment?" line? Also rather than having the down arrow under the up arrow, it would be nice if we can put them together on one line so it will look something like this:
Vote Up Vote Down Add Comment Vote Points where Vote Up and Vote Down are the images for vote up and down.
I suspect the code that handles this is written in the module file so I will have find the section and modify it. Any hints will be welcome.
Cheers,
Comment | File | Size | Author |
---|---|---|---|
#10 | vote_up_down-anon.patch | 390 bytes | jumpfightgo |
Comments
Comment #1
lut4rp CreditAttribution: lut4rp commentedThis issue has been fixed in the dev version. Thanks!
edit: rather, I think I should release beta3 with the fixes, and the latest SimpleTest files :-)
Comment #2
Mark_J CreditAttribution: Mark_J commentedhey thanks for that,
Is it possible to shed some light on the second question please? :) :)
I can try my luck by opening another issue?
Cheers,
Comment #3
batbug2 CreditAttribution: batbug2 commentedTried beta2 and -dev -- issue is there - anonymous user can vote as many times as they want!
Had to roll back to beta1, there is no bug there! Fix this ASAP please!
Comment #4
batbug2 CreditAttribution: batbug2 commentedAnd more info: if i put the vote_up_down.module file from the beta1 to the -dev pack, issue goes away, so I'd say the problem is somewhere in the vote_up_down.module file.
Comment #5
batbug2 CreditAttribution: batbug2 commentedOk, I have tracked down the issue: the problem is in the vote_up_down_vote() function, here
the error is here
$vote['uid'] = $uid;
In this case $uid for anonymous users is derived from the ip address in the vote_up_down module itself.
Though VotingAPI has its own way of detection of anonymous votes, and $vote['uid'] is optional.
If I comment out this line, anonymous users won't be able to vote multiple times on the same node. Hope this helps.
Comment #6
lyricnz CreditAttribution: lyricnz commentedYes, I think Vote Up/Down should not be dealing with uid at all here - it should be left to Voting API.
Comment #7
greggus-1 CreditAttribution: greggus-1 commentedI confirm.
Commenting out this line fixes wrong uid for anonymous users problem.
Comment #8
Clint Eagar CreditAttribution: Clint Eagar commentedThis problem exists in beta6 as well. I confirm that commenting out: $vote['uid'] = $uid; does the trick.
Comment #9
pfaffman CreditAttribution: pfaffman commentedMe too. Comment out 561 to disallow multiple anon votes.
Comment #10
jumpfightgo CreditAttribution: jumpfightgo commentedWorks for me too. I created a patch (works for both 6.x-1.x-dev and 6.x.1.x-beta6).
Comment #11
CarbonPig CreditAttribution: CarbonPig commentedWorks for me too!
Comment #12
tobiasbComment #13
tobiasbthe patch works also for me
Comment #14
jcisio CreditAttribution: jcisio commentedComment #15
lut4rp CreditAttribution: lut4rp commentedCommitted, finally! Thanks!
Comment #17
lubnax CreditAttribution: lubnax commentedsubscribing