Show stopping bug-o-rama!
| Project: | Social Insurance Number (CCK) |
| Version: | 6.x-2.4 |
| Component: | Code |
| Category: | bug report |
| Priority: | critical |
| Assigned: | Unassigned |
| Status: | closed |
Jump to:
So, I dumped this into a system I was building, and whenever I try to validate an SS field, it fails with a non-existent function error. So I started looking at the source. Several big problems: first off, the module is clearly repurposed from a similar phone number module, and the author, er, uh... well, he missed a few variable name changes for starters -- so there are places where the code is referencing stuff like $phone, and there's never been any such variable defined. Then there's the validation functions. They are being called directly instead of being run through the appropriate wrapper. Unfortunately, the wrapper pulls in the validation functions from an external file, so you can't really do it that way.
Anyway, in the attached patch, I standardized the variable names, repaired the wrapper calls, and fixed some grammar in the error messages. It works ok for me now, but I wouldn't put this module between my heart and a speeding bullet until it has suffered a fair bit more work.
| Attachment | Size |
|---|---|
| sin.patch | 3.38 KB |

#1
Taken into account in 6.2.5 release
#2
Automatically closed -- issue fixed for 2 weeks with no activity.