With only the share module enabled, the share admin page is quite confusing.
1. The "Click here" link on /admin/build/share/add doesn't work.
This is because the actual path for adding a share defined in hook_menu is /admin/build/share/add/share.
2. share_add_access() returns FALSE even for uid 1. It seems you're mixing up access to a menu item based on permissions with the presence of a menu item based on what modules are available. This doesn't look like a good approach to me -- you get an "access denied" message when in fact what's going on is that there simply isn't any STUFF to show in the first place (in this case because I'd enabled share.module and nothing else). Wrapping the menu item definition in a conditional statement that checks modules would be better.
Is it the case that share.module does nothing useful without further modules enabled? In which case, the admin page should just say something like "You need other modules such as foo and bar to use Share."
Comments
Comment #1
greenskin commented1. Link has been removed.
2. Menu item has been wrapped in an If statement checking for existing tabs. If none are found the menu item is not created.