Your module looks great and it is something I would like to use!
So here is a little bug: checking "My billing information is the same as my delivery information." checkbox, makes all the billing form disappearing, even if the VAT textbox is not filled.
I've seen the problem is $('#' + target + '-pane div.address-pane-table').slideDown(); in uc_cart.js, but I don't know how to prevent it from closing.

Comments

zmove’s picture

zmove commented

I get the same problem, unfortunately I believe that the ubercart JS isn't flexible enought and it was not made to understand custom added fields in a hook_form_alter.

To make it works correctly, I just change the order between the billind and the shipping pane.

It's probably doable but I don't really want to add a complex JS code that copy the VAT number when you click on the button. I think this is the role of the core to understand what are the fields under the pane and copy them properly.

I'm open to others opinion to change my mind, but I'm pretty sure mine is the right way ;)

ñull’s picture

ñull commented

My opinion is that the VAT number field should be visible with every address because what is now a shipping address can in the future be a billing address. This reasoning becomes specially important when you use the uc_address module.

attiks’s picture

attiks commented

I added a patch to #645260: Is there something wrong, which disables the javascript stuff amongst other fixes

wimh’s picture

wimh commented
Assigned: Unassigned » wimh
Status: Active » Fixed

The VAT field is now outside of the billing address fieldset, so this shouldn't be a problem anymore.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.