Allow for custom confirmation screen

Based on node_merge_action, I think that the existing 'configurable' attribute of actions can be used to achieve what you want. When you set it to TRUE, VBO automatically calls the action's form, validate and submit functions. It then passes to the action execution function the parameters set in the form. Would you still need a custom confirmation form then? Please take a look at taxonomy.action.inc for an example.

As a side note, I see that your action needs the 'aggregate' attribute to act on all selected nodes at once. I removed that feature from the code recently because the original request for it no longer stood. If you confirm that you need that feature, I will put it back in.

OK, Doesn't look like I need the aggregate ability, just me learning the various params.

While the configurable attribute does indeed show the form, it is with the list of nodes _before_ you select the ones you want.

So the flow would be:
select subset of nodes which may be duplicates & select the primary from the list
merge etc in the submit.

The flow I'm after is:
select subset of nodes which may be duplicates, submit
select which is the primary out of the subset, submit
merge etc in the submit.

As we have over 6000 nodes and building the select for the full list will be awful, making it much more usable with the additional step.

Please correct me if theres something I'm doing wrong with the configure, but I couldn't get it to work quite as required.

Thoughts?

How about this:
* Select the desired nodes in the main view
* Pass the selected list to the form, which allows the user to choose among those selected which is the primary
* Merge in the submit

Would that work for you? If so, I will make a small change to pass to the form the list of selected nodes.

Sounds fine to me. Love to see the small change, happy to test it out for you if you like.

The fix is ready (either pull from CVS branch DRUPAL-6--1 or wait 12 hours before Drupal.org refreshes the dev release). What's available now is that VBO will call the action's form function with a $context parameter which is an array with keys 'view' = the current view object and 'selection' = an array of selected node IDs. Please try it and let me know.

PS. Note that in the case of a single action, the action form is displayed on the first page along with the nodes to be selected. In that case, the action form will be called with 'selection' = null. You can inhibit that behaviour by explicitly setting the VBO option "Merge single action's form with node selection view" to FALSE.

That works quiet well. I've pasted the final code below for reference from our node_merge.action.inc Feel free to add to the tarball if you like.

<?php

function views_bulk_operations_node_merge_action_info() {
return array('views_bulk_operations_node_merge_action' => array(
'type' => 'node',
'description' => t('Merge duplicate nodes'),
'configurable' => TRUE,
'behavior' => array('changes_node_property')
));
}

function views_bulk_operations_node_merge_action(&$node, $context) {
// If this is not the primary node
if ($context['primary'] != $node->nid) {

// Update tables to now point at the new node Easy ones first.
db_query("UPDATE {comments} SET nid = %d WHERE nid = %d", $context['primary'], $node->nid);

// Now the tricky ones

// Comment statistics
$old_stats = db_fetch_array(db_query("SELECT * from {node_comment_statistics} WHERE nid = %d", $node->nid));
$new_stats = db_fetch_array(db_query("SELECT * from {node_comment_statistics} WHERE nid = %d", $context['primary']));

if ($new_stats['last_comment_timestamp'] < $old_stats['last_comment_timestamp']) {
$new_stats['last_comment_timestamp'] = $old_stats['last_comment_timestamp'];
$new_stats['last_comment_name'] = $old_stats['last_comment_name'];
$new_stats['last_comment_uid'] = $old_stats['last_comment_uid'];
}
$new_stats['comment_count'] = $new_stats['comment_count'] + $old_stats['comment_count'];

// Update the comment count and details on the new node.
db_query("UPDATE {node_comment_statistics} SET last_comment_timestamp = %d, last_comment_name = '%s', last_comment_uid = %d, comment_count = %d WHERE nid = %d",
$new_stats['last_comment_timestamp'], $new_stats['last_comment_name'], $new_stats['last_comment_uid'], $new_stats['comment_count'], $new_stats['nid']);
// Old node comment count is just left atm.

// And mark the node as unpublished, VBO does the update on return
$node->status = 0;
}
}

function views_bulk_operations_node_merge_action_submit($form, $form_state) {

// This identifies the primary node
$nodes = $form_state['values']['nodes'];
if ($nodes) {
$node = node_load($nodes);
drupal_set_message(t("Setting @title as primary", array('@title' => $node->title)));
return array(
'primary' => $form_state['values']['nodes'],
);
}
}

function views_bulk_operations_node_merge_action_form($context) {
$form = array();
$i = 0;

if ($context['selection']) {
$info = _views_bulk_operations_object_info_for_view($view);

foreach ($context['selection'] as $oid) {
if ($node = node_load($oid)) {
$nodes[$oid] = $node->title;
}
}

$form['nodes'] = array(
'#type' => 'radios',
'#options' => $nodes,
);
}

return $form;
}

Automatically closed -- issue fixed for 2 weeks with no activity.