Allow for custom confirmation screen

OK, Doesn't look like I need the aggregate ability, just me learning the various params.

While the configurable attribute does indeed show the form, it is with the list of nodes _before_ you select the ones you want.

So the flow would be:
select subset of nodes which may be duplicates & select the primary from the list
merge etc in the submit.

The flow I'm after is:
select subset of nodes which may be duplicates, submit
select which is the primary out of the subset, submit
merge etc in the submit.

As we have over 6000 nodes and building the select for the full list will be awful, making it much more usable with the additional step.

Please correct me if theres something I'm doing wrong with the configure, but I couldn't get it to work quite as required.

Thoughts?

Sounds fine to me. Love to see the small change, happy to test it out for you if you like.

That works quiet well. I've pasted the final code below for reference from our node_merge.action.inc Feel free to add to the tarball if you like.

<?php

function views_bulk_operations_node_merge_action_info() {
return array('views_bulk_operations_node_merge_action' => array(
'type' => 'node',
'description' => t('Merge duplicate nodes'),
'configurable' => TRUE,
'behavior' => array('changes_node_property')
));
}

function views_bulk_operations_node_merge_action(&$node, $context) {
// If this is not the primary node
if ($context['primary'] != $node->nid) {

// Update tables to now point at the new node Easy ones first.
db_query("UPDATE {comments} SET nid = %d WHERE nid = %d", $context['primary'], $node->nid);

// Now the tricky ones

// Comment statistics
$old_stats = db_fetch_array(db_query("SELECT * from {node_comment_statistics} WHERE nid = %d", $node->nid));
$new_stats = db_fetch_array(db_query("SELECT * from {node_comment_statistics} WHERE nid = %d", $context['primary']));

if ($new_stats['last_comment_timestamp'] < $old_stats['last_comment_timestamp']) {
$new_stats['last_comment_timestamp'] = $old_stats['last_comment_timestamp'];
$new_stats['last_comment_name'] = $old_stats['last_comment_name'];
$new_stats['last_comment_uid'] = $old_stats['last_comment_uid'];
}
$new_stats['comment_count'] = $new_stats['comment_count'] + $old_stats['comment_count'];

// Update the comment count and details on the new node.
db_query("UPDATE {node_comment_statistics} SET last_comment_timestamp = %d, last_comment_name = '%s', last_comment_uid = %d, comment_count = %d WHERE nid = %d",
$new_stats['last_comment_timestamp'], $new_stats['last_comment_name'], $new_stats['last_comment_uid'], $new_stats['comment_count'], $new_stats['nid']);
// Old node comment count is just left atm.

// And mark the node as unpublished, VBO does the update on return
$node->status = 0;
}
}

function views_bulk_operations_node_merge_action_submit($form, $form_state) {

// This identifies the primary node
$nodes = $form_state['values']['nodes'];
if ($nodes) {
$node = node_load($nodes);
drupal_set_message(t("Setting @title as primary", array('@title' => $node->title)));
return array(
'primary' => $form_state['values']['nodes'],
);
}
}

function views_bulk_operations_node_merge_action_form($context) {
$form = array();
$i = 0;

if ($context['selection']) {
$info = _views_bulk_operations_object_info_for_view($view);

foreach ($context['selection'] as $oid) {
if ($node = node_load($oid)) {
$nodes[$oid] = $node->title;
}
}

$form['nodes'] = array(
'#type' => 'radios',
'#options' => $nodes,
);
}

return $form;
}

UPDATE: I see now that you need to uncheck "Merge single action's form with node selection view", as mentioned above, for this to work. I have used this as a template to serve my specific needs, but it could be a good addition to the module if a few things were changed. For instance, as I mentioned, it would be great to be able to automatically change existing foreign key (node reference) values so that they reflect the new primary node. In my case, I did this by hardcoding a query to update the table for the single node reference field I'm concerned with on my site, because I'm not sure how to determine which fields *could* reference the merged nodes and update them programatically. I also added a query to update the search_node_links table.

I'd be willing to work on a more universal version of this action if anyone else is interested.

ORIGINAL COMMENT:
This does pretty much what I need, but it isn't working for me. The confirm screen does not allow me to select the primary node, as described. It just presents the default confirmation form (when I click "confirm" it appears to simply unpublish all selected nodes).

I would also like to modify the action to update any node reference fields that point to the merged nodes, so that they all point the primary. But I can figure that out. I just need help actually getting the second form working.

Thanks.

(EDIT Actually, I'm using 6.x-1.10)

Also, in singularo's action, this will work better at the end of the last function: