Port pift_server to Drupal 6

Gábor Hojtsy - January 21, 2009 - 17:17
Project:Project issue file testing
Version:6.x-2.x-dev
Component:Code
Category:task
Priority:normal
Assigned:Unassigned
Status:closed
Issue tags:drupal.org upgrade
Description

Creating issue for the drupal.org upgrade process to keep track of testing the 6.x branch server.

#1

boombatower - January 22, 2009 - 04:51
Project:Project Issue File Review» Project issue file testing
Version:6.x-1.x-dev» 6.x-2.x-dev

I think you want PIFT queue?

#2

Gábor Hojtsy - January 22, 2009 - 09:55
Title:Test 6.x code of pift_server running as part of the drupal.org upgrade» Port pift_server to Drupal 6
Version:6.x-2.x-dev» 5.x-1.x-dev

Ugh, yup. Looks like the platform was separated from the file tester. Sorry, I am not involved closely enough in this. Since the server is not on 6.x at all, retitling for the port.

#3

boombatower - January 22, 2009 - 15:59

PIFT is the code that runs on d.o.

PIFR is the code that runs on testing clients (computers that run tests), and t.d.o to manage testing and aggregate results back to d.o

#4

hunmonk - January 29, 2009 - 00:48

all code is ported to 6.x except the failed test mailing functionality (which we're not using on d.o yet anyways). i do need to test things a bit, but we're close.

#5

boombatower - January 29, 2009 - 06:44

oo...and ahead of schedule!

#6

hunmonk - January 29, 2009 - 14:51
Version:5.x-1.x-dev» 6.x-2.x-dev

ok, ran into some snags. the file API changed the database structure for both upload module and comment_upload module. this means that the file-related queries in the module will need to be updated/rewritten, along with any other core/comment_upload changes in form structure, etc.

on the good side, i fixed and tested the 5.x -> 6.x database upgrade for the module. there are some schema changes necessary, but mostly just to bring the 5.x db structure into place with the 6.x approach of doing inserts, and making sure the fields have consistent attributes -- no new or changed columns.

also, i fixed and tested the file import script that i originally used to import patch files. this script supports entering a range of file ID's, so it can be used to import missing files in the case where PIFT has been disabled on a site, to catch the file uploads that were submitted while it was off. all this means that even if i don't have the module itself working by the time d.o is upgraded, we can just leave it disabled and use the script to catch up when the module is fully ported.

#7

hunmonk - January 30, 2009 - 01:30
Status:active» fixed

this is now complete and committed.

#8

boombatower - January 30, 2009 - 23:33

Should the mail stuff just be removed? If anything I think it makes more sense for subscription to issue type notification.

#9

System Message - February 13, 2009 - 23:40
Status:fixed» closed

Automatically closed -- issue fixed for 2 weeks with no activity.

 
 

Drupal is a registered trademark of Dries Buytaert.