Posted by lyricnz on January 21, 2009 at 10:45pm
| Project: | Book access |
| Version: | 6.x-2.x-dev |
| Component: | Code |
| Category: | feature request |
| Priority: | normal |
| Assigned: | kiam |
| Status: | closed (fixed) |
Issue Summary
This would help prevent regressions, such as experienced recently, and allow test-driven development.
Comments
#1
I would definitely love to do this, but it's low priority due to time constraints.
I will also wait until unit testing is more integrated with drupal (d7?) and simpletest can pass it's own unit tests out of the box :)
#2
Does this help? It is a D6 SimpleTest (6.x-2.x-dev) that creates a few Book Pages in a Book, then updates a Role permission to add/remove permissions, checking each along the way. I haven't yet added tests for recent/current issues against this module, but that would be the logical next step.
336 passes, 0 fails, 0 exceptions
#3
per our IRC conversation, i'll integrate your tests into book_access, but simpletest functionality in d6 does not seem quite stable yet.
#4
FWIW, simpletest works very well in 6.x at this time. The unstable nature of it is a result of backporting changes from HEAD/D7, but very rarely will those changes break existing test suites--if they do, fixing them now simply lessens the work for the D7 upgrade of a given module.
#5
The tests in #2 are all passing, and look well written. I don't see any reason not to add this to dev. Once it's there, additional tests can be written to fix open issues.
#6
OK, sorry for not giving this much attention. I'll review this and release it if it doesn't break anything :)
#7
The D6 simpletest module has recently been updated, so there might be a few little things that need updating (static getInfo function, different base class name, etc). I'm sure you'll cope :)
#8
Just joinging after a convo with KiamLaLuno. I'll provide an updated testcase in the following hours for review.
#9
#10
#11
#12
Automatically closed -- issue fixed for 2 weeks with no activity.
#13
How is this "fixed"? The commit that refers to this issue doesn't contain any test.
http://drupal.org/cvs?commit=434132
#14
The SimpleTest files are present in branch 6.x-2 (and I forgot to commit them until 5 minutes ago).
#15
The SimpleTest files are present in branch 6.x-2 (and I forgot to commit them).
#16
Um, no they're not.
CVS messages for Book access
http://drupal.org/project/cvs/196193
book_access 6.x-2.x branch
http://drupalcode.org/viewvc/drupal/contributions/modules/book_access/?p...
#17
This is the right time.
#18
Automatically closed -- issue fixed for 2 weeks with no activity.