How about a SimpleTest for Book Access? [#362291]

Comment	File	Size	Author
#2	book_access.test	8.25 KB	lyricnz

Comment #1

harry slaughter

Omaha NE USA

commented 25 January 2009 at 21:25

Status:

Active

» Postponed

I would definitely love to do this, but it's low priority due to time constraints.

I will also wait until unit testing is more integrated with drupal (d7?) and simpletest can pass it's own unit tests out of the box :)

Log in or register to post comments

Comment #2

lyricnz commented 30 January 2009 at 01:28

Status:

Postponed

» Needs review

Status	File	Size
new	book_access.test	8.25 KB

Does this help? It is a D6 SimpleTest (6.x-2.x-dev) that creates a few Book Pages in a Book, then updates a Role permission to add/remove permissions, checking each along the way. I haven't yet added tests for recent/current issues against this module, but that would be the logical next step.

336 passes, 0 fails, 0 exceptions

Log in or register to post comments

Comment #3

harry slaughter

Omaha NE USA

commented 30 January 2009 at 01:33

Assigned:

Unassigned

» harry slaughter

per our IRC conversation, i'll integrate your tests into book_access, but simpletest functionality in d6 does not seem quite stable yet.

Log in or register to post comments

Comment #4

jhedstrom

English

Portland, OR

commented 24 March 2009 at 16:49

FWIW, simpletest works very well in 6.x at this time. The unstable nature of it is a result of backporting changes from HEAD/D7, but very rarely will those changes break existing test suites--if they do, fixing them now simply lessens the work for the D7 upgrade of a given module.

Log in or register to post comments

Comment #5

jhedstrom

English

Portland, OR

commented 24 March 2009 at 16:56

Status:

Needs review

» Reviewed & tested by the community

The tests in #2 are all passing, and look well written. I don't see any reason not to add this to dev. Once it's there, additional tests can be written to fix open issues.

Log in or register to post comments

Comment #6

harry slaughter

Omaha NE USA

commented 12 May 2009 at 18:03

OK, sorry for not giving this much attention. I'll review this and release it if it doesn't break anything :)

Log in or register to post comments

Comment #7

lyricnz commented 12 May 2009 at 21:24

The D6 simpletest module has recently been updated, so there might be a few little things that need updating (static getInfo function, different base class name, etc). I'm sure you'll cope :)