Is there a plan to convert this module to Drupal 6 since the other search and replace module doesn't support Regular Expressions.

I think changes to the form and menu functions (menu changes in D6) & to the .install file would be necessary.

CommentFileSizeAuthor
#4 scanner_D6_db_install_theme_left.patch11.48 KBRoi Danton
#3 scanner_D6_hook_menu.patch4.27 KBRoi Danton

Comments

kenorb’s picture

kenorb commented

+1

aasarava’s picture

aasarava commented

Would definitely like to convert to Drupal 6. Glad there's interest. Might be a couple weeks though before I can get to it. If anyone wants to take a first crack, that'd be much appreciated!

Roi Danton’s picture

Roi Danton commented
Status: Active » Needs work
StatusFileSize
new scanner_D6_hook_menu.patch4.27 KB

First patch only for hook_menu (short on time). Other hooks still need work. So it doesn't work with D6 yet.

Roi Danton’s picture

Roi Danton commented
StatusFileSize
new scanner_D6_db_install_theme_left.patch11.48 KB

New patch. Updated FAPI, l() and other things for D6. What still left is:

As long as these things aren't done the patch shouldn't include the core=6.x line in the .info file. So it can't be (accidentally) enabled in D6.

aasarava’s picture

aasarava commented

Many thanks for all your hard work on this, Roi. I'm planning to take a closer look at your patches this week (barring any sudden fires at work.) Will keep you posted!

aasarava’s picture

aasarava commented
Version: 5.x-2.0-beta1 » 6.x-1.x-dev
Assigned: Unassigned » aasarava
Status: Needs work » Needs review

Ok, I've finished upgrading the module to Drupal 6.x. The dev release should show up here pretty soon (the releases get scanned twice a day.) I've tested with standard nodes and nodes with CCK text and textarea fields and it looks good so far. Let me know if you see any other issues. Thanks for kick-starting this Roi.

Roi Danton’s picture

Roi Danton commented

No new commitments to D6 branch

Unfortunately the current 6.x-1.x version (2009-02-21-01:18) hasn't included the ported code of my patch (FAPI, l(), hook_menu etc). Furthermore the things mentioned in #5 are still undone.

The reason is simple: It seems the 6.x branch hasn't the correct version. When I download the 6.x-1.x-dev release the module version is still 1.4 from 2008/12/04 01:17:52. Looking at your projects CVS log no code has been committed since December. Please rail against the one who created the 6.x-1.x-dev branch but hasn't committed the new code. ;)

aasarava’s picture

aasarava commented

Yeah, that'd be me. :) Sorry about that. Let's try again. Should be committed and ready to go.

Roi Danton’s picture

Roi Danton commented

Seems to work. However, I haven't tested the D6 version using replacement in textfields and with regexp yet.

By the way, please remove the t() function out of the menu titles. t() is called automatically for menu/form titles/descriptions (lines 63, 68, 73, 80 etc).

aasarava’s picture

aasarava commented
Status: Needs review » Closed (fixed)

Ok, t() has been removed from 6.x-dev and project has been released as 6.x-1.0. Thanks for your help. Closing.