Uninstall hook missing

Posted by beltofte on January 22, 2009 at 1:40pm

Issue Summary

The uninstall hook is not implemented in scheduler.install, which means that the databasetables, variables etc. are not cleaned up when uninstalling the module.

Comments

#1

Posted by Eric Schaefer on January 26, 2009 at 6:38pm

You are right. We should have an uninstall procedure.

#2

Posted by Eric Schaefer on April 18, 2009 at 2:18pm

Status:

active

» needs review

Here is a patch with the uninstall function. Please review.

Attachment	Size
scheduler_uninstall.patch	705 bytes

#3

Posted by jonathan1055 on April 19, 2009 at 9:04am

Looks good. Two minor points:
(a) why is it necessary to delete the 'scheduler_date_format' variable explicitly, when it would appear that the db_query will delete this anyway?
(b) when the patch was applied I got the message 'stripping trailing CRs from patch'. It worked fine, though.

Jonathan

#4

Posted by Eric Schaefer on April 19, 2009 at 10:05am

a) Originally I wanted to delete all variables via variable_del().
b) I diff'ed with eclipse in Windows. I guess you patched with something unixey?

I want to make some changes to this anyways. Larry Garfield pointed out it would be better to track removed node types via hook_node_type() and remove their configuration variables imediately ('scheduler_NODETYPE' and 'scheduler_touch_NODETYPE'). On uninstall only the variables regarding the remaining node types need to be removed (e.g. via node_get_types()). Sound much better and cleaner to me. I'll try it later today.

Thanks for testing.