Uninstall hook missing

You are right. We should have an uninstall procedure.

Here is a patch with the uninstall function. Please review.

Looks good. Two minor points:
(a) why is it necessary to delete the 'scheduler_date_format' variable explicitly, when it would appear that the db_query will delete this anyway?
(b) when the patch was applied I got the message 'stripping trailing CRs from patch'. It worked fine, though.

Jonathan

a) Originally I wanted to delete all variables via variable_del().
b) I diff'ed with eclipse in Windows. I guess you patched with something unixey?

I want to make some changes to this anyways. Larry Garfield pointed out it would be better to track removed node types via hook_node_type() and remove their configuration variables imediately ('scheduler_NODETYPE' and 'scheduler_touch_NODETYPE'). On uninstall only the variables regarding the remaining node types need to be removed (e.g. via node_get_types()). Sound much better and cleaner to me. I'll try it later today.

Thanks for testing.

Committed: http://drupal.org/cvs?commit=199040

Trying to keep 5.x in sync: http://drupal.org/cvs?commit=199044