in layout/threecol_33_34_33/panels-threecol-33-34-33.tpl.php

<div class="panel-display panel-3col-33 clear-block" <?php if (!empty($id)) { print "id=\"$id\""; } ?>

should be

<div class="panel-display panel-3col-33 clear-block" <?php if (!empty($id)) { print "id=\"$css_id\""; } ?>

Other layout templates could suffer the same issue, but not verified.

I doubt a patch is necessary, but let me know and I'll make one.

CommentFileSizeAuthor
#5 panels-362754.patch950 bytesdawehner

Comments

darkodev’s picture

darkodev commented

Sorry, template files are found in layouts/, not layout/

jadwigo’s picture

jadwigo commented

The correct line would be:


<div class="panel-display panel-3col-33 clear-block" <?php if (!empty($css_id)) { print "id=\"$css_id\""; } ?>>
jadwigo’s picture

jadwigo commented
Title: wrong variable in 3 column layout causes css id to be the panel id, not the css id, resulting in id="1" for example » Invalid xhtml generated in 3col 33/34/33 template

Title was : wrong variable in 3 column layout causes css id to be the panel id, not the css id, resulting in id="1" for example

jadwigo’s picture

jadwigo commented
Version: 6.x-2.0-alpha3 » 6.x-3.0-alpha4

since it's not mentioned I guess it's still needed

dawehner’s picture

dawehner
Primary language German
commented
Status: Active » Needs review
StatusFileSize
new panels-362754.patch950 bytes

and here is the patch for it

easy and fast patch

merlinofchaos’s picture

merlinofchaos commented
Status: Needs review » Fixed

Fix committed! Thanks!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.