By hanbyeol on

I made a drupal site.
After submitting a topic, users can't edit their own topic. I couldn't find 'edit forum topic' when I log in as a common user. I checked Permission configuration but I can't make it. Forum doesn't support editing permission for common users?

Do I have to modify forum.module? Let me know the solution.

Thanks~

Comments

Russell McOrmond’s picture

Russell McOrmond commented

I don't see a reply to this question. Is this a missing feature in the forum system? I note the ability to set permissions to "edit own pages" and "edit own stories", but no "edit own forum topics". There is only "create forum topics" and once they are created only the administrator can edit them.


I have the same question about comments -- I want to be able to allow users to edit their own comments.


Russell McOrmond, Internet Consultant: FLORA Community Consulting

stelman’s picture

stelman commented

I have been trying to figure this out too.

TheoGB’s picture

TheoGB commented

It's annoying and true even on this site.

It seems the only way people can edit their own forum posts is to have full node access, which is obviously very unhealthy. The only way to fix it will be to alter the mod in some way but I don't know how to do that. :(

stabani’s picture

stabani commented

if any body finds the solution please let me know. That is something I want on my site too :)

tom@scriptaholics.com’s picture

tom@scriptaholics.com commented

Hi,

I recently made a patch to do this because I wanted this functionality on my own site and was going to submit it as a patch only to find out that someone had beaten me to it. The patch is at http://drupal.org/node/11427, it is for 4.5rc but from what I've found the code works in 4.5 (it's exactly the same as the patch I made).

Hope it helps.

TheoGB’s picture

TheoGB commented

Cheers for that.

I implemented it as best I could, but I'm only on 4.4.2.

I got the check box appearing in the list but it didn't seem to affect the ability of the person to edit their forum topics...

carlmcdade’s picture

carlmcdade commented

If you don't know the debug ide then seeing the patch code you will not follow the instructions In the hook_perm there is a - and a + to show the changes.

This was never made into a feature request? Coming from phpBB and other boards it should be a given feature. Thanks for the code this was bugging the heck out of me.

function forum_access($op, $node) {
+  global $user;
+  
   if ($op == 'create') {
     return user_access('create forum topics');
   }
+  
+  if ($op == 'update' || $op == 'delete') {
+    if (user_access('edit own forum topics') && ($user->uid == $node->uid)) {
+      return TRUE;
+    }
+  }
 }
 
 /**
  * Implementation of hook_perm().
  */
 function forum_perm() {
-  return array('create forum topics');
+  return array('create forum topics', 'edit own forum topics');
 }

Should look like this when your done.

/**
 * Implementation of hook_access().
 */
function forum_access($op, $node) {
  global $user;
  
   if ($op == 'create') {
     return user_access('create forum topics');
   }
  
  if ($op == 'update' || $op == 'delete') {
    if (user_access('edit own forum topics') && ($user->uid == $node->uid)) {
      return TRUE;
   }
  }
 }
 
 /**
  * Implementation of hook_perm().
  */
 function forum_perm() {
  return array('create forum topics', 'edit own forum topics');
 }

---------------------------
info for Drupal installation
__________________________
Carl McDade
Information Technology Consult
Team Macromedia
www.hivemindz.com

yossarian’s picture

yossarian commented

This patch gives users DELETE NODE permission, which would allow them to wipe out an entire thread, not jsut their own post.

If you don;t want that, change:
if ($op == 'update' || $op=='delete')

to

if ($op == 'update')

stelman’s picture

stelman commented

thanks!

TheoGB’s picture

TheoGB commented

This doesn't work for me:

function forum_access($op, $node) {
  global $user;
 
  if ($op == 'view') {
    return $node->status;
  }

  if ($op == 'create') {
    return user_access('create forum topics');
  }
  
//  if ($op == 'update' || $op == 'delete') {
  if ($op == 'update') {
    if (user_access('edit own forum topics') && ($user->uid == $node->uid)) {
      return TRUE;
    }
  }
}

function forum_perm() {
  return array('create forum topics', 'edit own forum topics');
}

If I don't leave in the 'view' thing at the start, no one's allowed permission to view the forum posts, and if it is in there then there's no change to the existing way in which it functioned, i.e. no editing allowed...

Any ideas?

blud’s picture

blud commented

Why isn't this a feature in drupal? It's like one of the most basic forum features :| Now I have to muck around and figure out how to do code stuff.

This thread is kind of old, does anyone have a foolproof way of adding post editing ability?

carlmcdade’s picture

carlmcdade commented

No, they have not added it as a feature. If you follow the steps in this thread and use the patch then you are set.

Probably the reason that it has not been added is because no users have screamed loud enough for it and the Drupal team seem to think preview is enough which sucks.
---------------------------
www.hivemindz.com (running PHP5)
www.fireorb.org (documentation and hacks)
__________________________
Carl McDade
Information Technology Consult
Team Macromedia

blud’s picture

blud commented

Well I didn't use any patches, but I opened up forum.module and edited the source to match the code in this thread. Now my users can edit their posts. Thinking that preview is good enoug misses the point, for example on my site the users have a "Things to do" thread, and the first post in their thread gets continually updated by them (now that I added the code for updating)