Posted by yngvewb on January 23, 2009 at 2:11pm
Jump to:
| Project: | Similar entries |
| Version: | 6.x-1.0 |
| Component: | Code |
| Category: | task |
| Priority: | normal |
| Assigned: | yngvewb |
| Status: | closed (fixed) |
Issue Summary
When using the option "Only show the similar nodes in the same category as the original node" I wanted to exclude some vocabularies in the block admin interface to similar.
I have a couple of vocabularies that is for editorial status, and a status as "need review" should not necessarily relate to other nodes with same status.
Here is the patch, I don’t think the patch is done the "right" Drupal way, but anyway, should be easy to follow.
| Attachment | Size |
|---|---|
| similar.module.patch | 3.02 KB |
| Similarentries-blokk.png | 12.31 KB |
Comments
#1
Does this patch work for 6.x and will this be rolled into 5.x and 6.x CVS?
#2
This patch is for 5.2, not for 6.x
I'm not the maintainer of the module, but I think this is a natural improvement, and should be included in CVS.
And about the 6.0, I haven’t looked into 6.0 yet, but I guess it should be easy to integrate with some intelligent copy and paste. Just give it a try :-)
#3
You're right, you didn't do it in in the proper Drupal way, so even though I pasted in the changes by hand into 5.x-2, in the future, I will reject any patches from you that don't comply with http://drupal.org/patch and http://drupal.org/node/318 (as evaluated by http://drupal.org/project/coder). Specifically, I don't have a c:\ on my drive, which your patch references, you used tabs which made my eyes bleed a little bit, and you camelCased a variable.
#4
Lesson learned :-) I will obey the drupal coding standards from now on. Thanks for adding the patch!
#5
With views integration in 7.x-2.x this patch will no longer be ported. Filtering by taxonomy can be accomplished through the default view now.