Exclude vocabularies from similar entries

yngvewb - January 23, 2009 - 14:11
Project:Similar Entries
Version:6.x-1.0
Component:Code
Category:task
Priority:normal
Assigned:yngvewb
Status:patch (to be ported)
Description

When using the option "Only show the similar nodes in the same category as the original node" I wanted to exclude some vocabularies in the block admin interface to similar.

I have a couple of vocabularies that is for editorial status, and a status as "need review" should not necessarily relate to other nodes with same status.

Here is the patch, I don’t think the patch is done the "right" Drupal way, but anyway, should be easy to follow.

AttachmentSize
similar.module.patch3.02 KB
Similarentries-blokk.png12.31 KB

#1

spiffyd - January 24, 2009 - 09:50

Does this patch work for 6.x and will this be rolled into 5.x and 6.x CVS?

#2

yngvewb - January 29, 2009 - 13:38

This patch is for 5.2, not for 6.x

I'm not the maintainer of the module, but I think this is a natural improvement, and should be included in CVS.

And about the 6.0, I haven’t looked into 6.0 yet, but I guess it should be easy to integrate with some intelligent copy and paste. Just give it a try :-)

#3

deekayen - January 29, 2009 - 15:24
Version:5.x-2.0» 6.x-1.0
Status:needs review» patch (to be ported)

You're right, you didn't do it in in the proper Drupal way, so even though I pasted in the changes by hand into 5.x-2, in the future, I will reject any patches from you that don't comply with http://drupal.org/patch and http://drupal.org/node/318 (as evaluated by http://drupal.org/project/coder). Specifically, I don't have a c:\ on my drive, which your patch references, you used tabs which made my eyes bleed a little bit, and you camelCased a variable.

#4

yngvewb - February 2, 2009 - 10:30

Lesson learned :-) I will obey the drupal coding standards from now on. Thanks for adding the patch!

 
 

Drupal is a registered trademark of Dries Buytaert.