An old behaviour from 4.6 and pre form-api is missing on admin/themes:

if you set a theme to default which is currently not enabled.
it will be set as the default theme but the theme stays disabled. so you dont see the theme.

as it was and should be:
a theme which gets default theme and is currently disabled should get enabled automatically

CommentFileSizeAuthor
#3 system.module_16_0.patch902 byteschx
#1 system.module_16.patch899 bytesTobias Maier

Comments

Tobias Maier’s picture

Tobias Maier commented
Assigned: Unassigned » Tobias Maier
Status: Active » Needs review
StatusFileSize
new system.module_16.patch899 bytes

here is my patch.

it enalbles the default theme automatically

Tobias Maier’s picture

Tobias Maier commented
Title: old behaviour missing on admin/themes » admin/themes: theme which is set to default does not get enabled automatically
chx’s picture

chx commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new system.module_16_0.patch902 bytes

Some more spaces would be nice. "and snow and an earthquake" :)

dries’s picture

dries commented
Priority: Critical » Normal
Status: Reviewed & tested by the community » Fixed

Committed to HEAD.

Dublin Drupaller’s picture

Dublin Drupaller commented

Drupal still doesn't pick up on the default theme. Just tried the latest version of CVS..the patch appears to be applied in the system.module (HEAD) but Drupal is still not picking up the default theme.

Am trying to work out why that's the case myself..just thought I'd flag it up here while I'm trying to do that.

Dub

Dublin Drupaller’s picture

Dublin Drupaller commented
Status: Fixed » Active

sorry, to be pedantic..Drupal doesn't pick up the theme marked as default under ADMIN-->> THEMES

e.g. if you have the BLUEMARINE and CHAMELEON enabled and CHAMELEON set to DEFAULT, Drupal still picks up BLUEMARINE as the default theme.

Dub

Dublin Drupaller’s picture

Dublin Drupaller commented

Sorry...just noticed..when you log out...Drupal does pick up on the default theme...but when you login again as admin it loses the default.

hope that makes sense..

Dub

killes@www.drop.org’s picture

killes@www.drop.org commented

is it possible that your admin user has chosen one theme as personal theme?

Dublin Drupaller’s picture

Dublin Drupaller commented

Nope. It seems Drupal does that automatically with no user intervention..i.e. When you enable a new theme and set it to default, under MY ACCOUNT the previously selected theme is automatically set as the default theme with no user intervention.

while checking that I stumbled on another possible bug/problem..which is probably related..

i.e. clicking on RESET TO DEFAULTS breaks Drupal. No themes are enabled, Bluemarine is set to default, but, since it's not enabled..it doesn't work.

I'm deleting and reinstalling a testbed version of Drupal CVS from scratch to see if I can recreate the problems...if anyone else can try the RESET TO DEFAULTS thing on a test bed install of Drupal CVS to see if they are experiencing the same..?

Will post back up here when I determine if it is just a duff install on my part or an actual problem..

Dub

Dublin Drupaller’s picture

Dublin Drupaller commented
Status: Active » Closed (fixed)

Quick update:

I removed my Drupal CVS testbed and re-installed from scratch and the theme issue was indeed a mistake on my part - when the first account was created, I changed the password and when saving that change, I was also setting the default theme.

Dub