Secondary/Primary menus disappear after cvs upgrade. [#36335]

I upgraded to the latest cvs, which includes the new primary links menu patch:
http://drupal.org/node/22215

I am not sure this is a bug or intended behavior. Downgrade category to support-request as appropriate.

www.wechange.org:
Using the bluemarine style, I had a series a primary (white) /secondary links (light blue, above primary), displayed at the top right corner of the header. After the upgrade, those links have disappeared. I enabled the Primary Links and Secondary links menus, but I can only place them on the sides (left or right) not at the top because the styling is ugly and do not fit the header.

1- Is this the intended behaviour?
2- Is it a matter for me or someone to update the style.css so that the links display like before in the headers?

My test platform on my local machine still display the links as before the upgrade. which has be confused because the code base is the same locally and on the remote site, so I don't understand what went wrong (if anything).

thanks.

Comments

Comment #1

Richard Archer CreditAttribution: Richard Archer commented 4 November 2005 at 11:25

The intention is that all legacy links get imported into the new system and the site displays exactly the same as it was before.

There was a glitch in the intial patch that was committed... the menus were being displayed as a bullet-list instead of the traditional link | link | link format. This was fixed about 4 hours ago, so you might like to make sure you have that extra patch installed.

You can check if you do... bluemarine should call print theme('links', $secondary_links).
Not theme('menu_links', $secondary_links).

...Richard.

Comment #2

beginner CreditAttribution: beginner commented 4 November 2005 at 15:18

thank you.

I updated but the problem persists.

<?php if ($secondary_links) { ?><div id="secondary"><?php print theme('links', $secondary_links) ?></div><?php } ?>
     <?php if ($primary_links) { ?><div id="primary"><?php print theme('links', $primary_links) ?></div><?php } ?>

where are $primary_links and $secondary_links declared???

I'm looking into the code, looking for the answer but the more I look, the more I'm puzzled.

I have a local (test) and a remote (live: www.wechange.org ) site. Both run the same cvs code (updated several times today, including page.tpl.php). Both run with the same data: actually, I made a backup of my remote/live data, and imported it into a new DB locally to test with, so I'm sure the data on both sides is the same.
Yet, locally, the links display as before, and as intended, but on the live site, the primary/secondary links do not appear. also, I have disabled the cache.

I'm very puzzled by this (same data, same code, different behaviour). And I am currently trying to debug this, testing where something has gone awry.

That's why I'm starting from the theme template, but no matter how I grep for it, I cannot find where $primary_links is declared. I grepped both the php code and the sql dump. I found that it used to be declared in variable -> theme_settings in the DB, but no longer.

But since it's still used in the template, those vars must be declared somewhere.

Am I missing something obvious?

Comment #3

beginner CreditAttribution: beginner commented 4 November 2005 at 15:31

Am I missing something obvious?

yes:

[cvs.drupal.org]$ grep -R "secondary_links" *
...
themes/engines/phptemplate/phptemplate.engine:    'secondary_links'     => menu_secondary_links(),
...

still debugging...

Comment #4

Richard Archer CreditAttribution: Richard Archer commented 4 November 2005 at 22:06

What's in your database for:
variables menu_primary_menu and menu_secondary_menu
and menu table?

Comment #5

beginner CreditAttribution: beginner commented 5 November 2005 at 02:30

menu_secondary_menu s:3:"152";
menu_primary_menu s:3:"147";

and in menu:

147  0      Primary  links                                                       0 115
148 147  node/1   Introduction introducing WeChange.org                            0 118
...
152 0      Secondary links                                                    0  115
153 152  node/8     Project list  (Project list)                                0  118
...

etc...

If you don't have any immediate idea what it could be, never mind: I'll carry on investigating myself. I'll update here as appropriate.

It's a good opportunity to learn the code ;-)