How do I contribute? [#36351]

I have undertaken some work on the Event module and would like to feed this back, but am not sure how to go about it and want to avoid stepping on anybody's toes. This has all been done against the 4.6.0 version, not cvs. Here's what I have done:

1) Added blocks which are determined dynamically by Flexinode type. This means that you can have separate blocks displayed for separate types of events (see here also for a discussion on this point). Note that the original "all in one" block is still available.

2) Added a setting to determine how far in the future events will be displayed in the blocks (eg, if you set it to "30" then dates which take place 45 days in the future will not show up in the events block).

3) Added a "cron" hook to delete past events after a certain (configurable via settings) number of days has passed.

4) Translated into French and Spanish (German to follow).

I have cvs access and would gladly contribute this - instructions or just a "go-ahead" from the "owners" of Event module would be welcome. Obviously, I have a vested interest! I would like to see this in 4.7 without having to go through the business of "repatching" my changes in.

Comments

Comment #1

killes@www.drop.org CreditAttribution: killes@www.drop.org commented 4 November 2005 at 14:45

I'd prefer to see your contributions put into seperate modules that reside in the contrib directory.

Comment #2

joel_guesclin CreditAttribution: joel_guesclin commented 7 November 2005 at 14:17

I wouldn't mind doing it this way I guess. I presume you mean modules in the contrib directory for Event module plugins that I can see in the CVS version?

Is there some documentation as to how these things work. For example, if I do a function with the same name as one in the Event module, does it override the Event module, or should I make them rigorously separate?

Thanks, and I will be happy to contribute - though I guess probably not until 4.7!

Comment #3

killes@www.drop.org CreditAttribution: killes@www.drop.org commented 7 November 2005 at 15:44

Version:	4.6.x-1.x-dev	» 5.x-2.x-dev
Priority:	Critical	» Normal
Status:	Active	» Fixed

Yes, he contrib directory is meant for that. No, you can't override php functions. You should name your functions according to Drupal conventions, eg _foo. If your module is named event_foo the help hook shoudl be named event_foo_help and all module functions should start with event_foo.