In Drupal 6.x, on the User settings page (?q=admin/user/settings), there is the option to enable and disable user signatures.
However, this feature is entirely dependent on the Comment module - i.e. if Comment is disabled, enabling user signatures does nothing.
If, however, Comment module is enabled and user signatures are enabled, the "Signature settings" fieldset appears on the user profile editing page at (?q=user/[uid]/edit) - this is because the form comes from hook_user, and Comment module is the one implementing it.
If Comment module implements hook_user and provides the form - and since Comment modules also displays the signatures - Comment module should also own the settings enabling and disabling user signatures.
| Comment | File | Size | Author |
|---|---|---|---|
| #5 | node_signatures.patch | 4.04 KB | dawehner |
| #1 | drupal_signature.png | 35.43 KB | dawehner |
| #1 | phpbb.png | 96.39 KB | dawehner |
Comments
Comment #1
dawehnerSure this makes sense, but i realized that signatures are not attached to the nodes itself.
This is a different behaviour to every other forum system for example phpbb, there the signature is attached also to the "node"
, see screenshot attached
and then the signature should keep in user module, because it can be used in other places too
Comment #2
dawehnerso here is a first path which adds the signature of the node
but it has to be added "
" to the signature and support for chameleon.
shouldn't be template_preprocess_node and template_preprocess_comment be in node/comment module?
Comment #3
horncologne commentedDid you mean to upload a patch? It doesn't seem to have made it though ...
In any case, I'd really like to see a patch that solves this dependency issue before we start talking about new features.
Comment #4
dawehnerso first the patch,
it adds the signature to nodes and not only comments
so the signature should keep in user, because its definitve connected to the user and not connected to comment.
Comment #5
dawehnerComment #6
horncologne commentedThis is a nice feature request - now please go start another thread. This has nothing to do with the dependency bug I reported.
Comment #7
dawehnerthx
if you are interested : http://drupal.org/node/363878
back to this issue: i don't think that signature belongs to the comment module. Perhaps some people want to display the signature for users, on the user profile
Comment #8
dawehneri had some thinking about it:
why not create a signature module, which handles all the stuff
Comment #9
horncologne commentedThis must be a two-step process: 1st - fix the dependency problem. 2nd - Discuss implementation.
Comment #10
horncologne commentedPlease file a feature request or write a module once this technical problem has been resolved.
This issue must focus solely on removing the dependency as described.
Comment #11
sun.core commentedWho says that there can be only one Comment module and that there can be only one module that supports user signatures? Do you know Guestbook module? Privatemsg module? The list is quite long.
Comment #12
srcsantos commentedI know this makes me sound a little stupid (because i sure feel that way now), but i just spend a little more than an hour trying to find out why the option to edit the signature was gone, only to realise that the signature dependes on the Comment module, wich i had disabled.
Now, while i agree with #8, i think that an alternative would be to change the signature handling to the User module, since my case is something like what is described in #7.
Whatever the solution, the thing that really doesn't make much sense to me is having an option to enable signature support, in User Settings, if the referred option is rendered useless when the Comment module is disabled.