incorporate Search Files in Drupal default Search box

cmgui,

It should be doable although I am not sure on the impact that change would have on the server running the search.

Thanks
Robert

hook_update_index(). Will feed all the data into the standard search box. But as I said I have no idea how that will effect servers.

Thanks
Robert

OK so I'm not familiar enough with drupal and the idea of "hook" to know exactly what to do with hook_update_index() as rmiddle mentions.

But I did need this feature, and specifically I want to return a node not a file on the search so I really just want all the attachment text to be included in the node's index.

I'm also not 100% sure how to produce a patch file, though I'm on windows I've got a version of diff and I'll try to figure it out if anyone tells me this is a rational update.

But here is my hack that does the trick.

So using:

Search Files 6.x-2.x-dev

In the file:

search_files/modules/search_attachments/search_attachments.module

In the function:

_search_attachments_index_file

@ line 138 I inserted the following code

	// get nid  out of uplaods table from lookup fid
	// also get the current data in the table so we can add to it
		$file_plus = db_fetch_object(db_query("SELECT f.*, d.data, u.nid FROM {files} f JOIN {upload} u USING(fid) INNER JOIN {search_dataset} d ON f.fid = d.sid WHERE fid = %d", $file->fid));
	search_index($file_plus->nid, 'node', $contents . ' ' . $file_plus->data); 

The impact on the server is an extra query and insert during indexing, but there should be no impact during a search. This does "taint" the search index with attachment text, (which is what I wanted) if that is not what you want then this may not work for out for you.

Fabulous Module, thanks.

haleagar,

Yea that is what I meant by impact on the server. 1st there is the increase load of inserting the data into the search index. AKA tainting the search index. 2nd this will add all the search data into the index so it will increase storage used by the mysql server and that will increase the time it takes to do any searches. But all the items will be in the main search. To me it makes since to have this as an option but I am not a maintainer of this module so my view means nothing.

Thanks
Robert

I, too, needed to have file attachments come up within the normal content search results. To do this, I took the the search_attachments submodule and changed it into a module called search_attachments_inline. This module indexes file attachments to nodes, and it includes text extracted from the attachment in the search database for the node.

Attached are search_attachments_inline.info, search_attachments_inline.module, and search_attachments_inline.install.

Normally, Drupal includes the snippet of node text with matching terms as part of the search results. I wanted the snippet of attachment text to appear when a search matches text in the attachment. I had to make one nasty hack to Drupal core node.module to make this work. There may be a better way to do this, but I didn't find a suitable hook in node.module to make it work.

In any case, I'm willing to roll this into a proper tar.gz if necessary. Perhaps this could be incorporated into the Search Files project as an additional submodule? Or as a separate project?

Oh, and here is a diff of the nasty patch of node.module that I did. The patch is against Drupal 6.10.

--- node.module.orig    2009-05-15 22:10:42.000000000 +0100
+++ node.module 2009-05-15 22:45:58.000000000 +0100
@@ -1284,6 +1284,11 @@ function node_search($op = 'search', $ke
         // Fetch terms for snippet.
         $node->body .= module_invoke('taxonomy', 'nodeapi', $node, 'update index');

+        // Get attachment text for snippet - added by imac 20090515
+        if (module_exists('search_attachments_inline') && user_access('view uploaded files')) {
+         $node->body .= module_invoke('search_attachments_inline', 'nodeapi', $node, 'update index');
+        }
+
         $extra = node_invoke_nodeapi($node, 'search result');
         $results[] = array(
           'link' => url('node/'. $item->sid, array('absolute' => TRUE)),

-Ian

subscribing

See #368195: Combining Search Files module with Search module, which is an almost identical issue. I think the code there is probably better, but the idea of a separate module suggested here seems good to me.

Subscribing

Hey there,

I am starting to face this problem, too, but didn't yet look far into the code. I'd like to first evaluate different approaches. cmgui's solution of creating or porting that search_all.module seems reasonable to me. The paging problem could be overcome by creating a single result page which shows all three (or more if applicable) result sets (content, files, users) in three different columns rather than combining them in one list. This could serve as a first glance at all results (like an extended version of Google's "I feel lucky" button). Instead of displaying the pager below these list there could be a "see more [content|files|users] results" which leads the normal separated search pages.

@cmgui: Is your search_all.module available to download and work on? I think I have to come up with some solution within the next 6 weeks one way or the other to display both content and file results on one page and your approach could be some head start.

Best,
Paul

Look at http://drupal.org/node/368195#comment-2834322

Thanks for the search_attachments_inline module!
It worked for me to index and show files from CCK filefield,
only i`ve changed query (line 32) to:

$result = db_query('SELECT * FROM {files} f INNER JOIN {content_field_file} r ON f.fid = r.field_file_fid WHERE r.vid = %d ORDER BY f.fid', $node->vid);

And for some reason another way mentioned here http://drupal.org/node/368195#comment-2834322 doesn`t work (for my needs).