Download & Extend
Issues

move template_preproces_node/block out of theme.inc

Posted by dawehner on January 25, 2009 at 1:43pm
Project:Drupal core
Version:7.x-dev
Component:base system
Category:feature request
Priority:normal
Assigned:Unassigned
Status:closed (fixed)

Issue Summary

i recognized the functions template_preprocess_node/block in the file inclues/theme.inc

this is for me not the logically place, they should be in modules/node/node.module and modules/block/block.module

any oppinions about it?

Login or register to post comments

Comments

#1

Posted by dawehner on January 25, 2009 at 1:51pm
Status:active» needs review

here is a fast patch

perhaps a argument for doing this is also that you could include theme.inc without want to use node/block module. Only use the awesomeness of stuff like theme_item_list

AttachmentSizeStatusTest resultOperations
move_preprocess_node_block.patch8.01 KBIdleFailed: Failed to apply patch.View details

#2

Posted by System Message on January 26, 2009 at 9:25pm
Status:needs review» needs work

The last submitted patch failed testing.

#3

Posted by dawehner on April 29, 2009 at 9:25pm
Status:needs work» needs review

rerole

it seams that preprocess_block moved to block.module

AttachmentSizeStatusTest resultOperations
move_preprocess_node_block.patch5.41 KBIdlePassed: 11308 passes, 0 fails, 0 exceptionsView details

#4

Posted by cburschka on May 22, 2009 at 9:32am
Status:needs review» reviewed & tested by the community

Good call. If the block function has already moved, it makes sense to move the node function too...

#5

Posted by Dries on May 22, 2009 at 11:34am
Status:reviewed & tested by the community» fixed

Committed to CVS HEAD. Thanks.

#6

Posted by System Message on June 5, 2009 at 11:40am
Status:fixed» closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

nobody click here