Closed (won't fix)
Project:
Menu Breadcrumb
Version:
6.x-1.1
Component:
Code
Priority:
Normal
Category:
Feature request
Assigned:
Unassigned
Reporter:
Created:
26 Jan 2009 at 13:54 UTC
Updated:
9 Oct 2009 at 02:26 UTC
Jump to comment: Most recent file
Comments
Comment #1
mrfelton commented+5 for this patch for me - in my opinion, this module is unusable without this patch applied. Please can somebody commit this.
Comment #2
elijah lynn+1
Comment #3
balabushka commentedty so much, just wanted to code that myself
Comment #4
dboulet commentedThis feature would be very useful, especially for multilingual sites with separate menus for each language. Patch needs work...
Comment #5
xurizaemondboulet, can you please clarify what needs work about the above patch? Seems you mean it doesn't handle per-language menus appropriately - can you describe the issue you see in that case?
Comment #6
dboulet commentedSorry xurizaemon, I should have described the work that was needed in more detail--now, over 2 months later, I don't even recall exactly what the issue was.
I'm pretty sure that the problem wasn't with using multi-lingual variables, I think that it was a problem with the logic that decides when to use the default menu. Using the last patch, the default menu will always be chosen--whether the current menu item belongs to that menu or not. Seems to me that the default should only be used as a fallback when a conflict is detected, when there exists more than one menu item that points to the current path. Does that make sense, or have I misunderstood the logic behind the patch?
Comment #7
pshahmumbai commentedThe CVS version already does this :)
Comment #8
pshahmumbai commentedComment #9
dboulet commentedA black list/white list option, though a nice feature, is not exactly what we are after. I was thinking about this some more, and what we really need to to give each menu a weight so that they can be given an order of preference, as suggested by jweowu in #556552: Menu weights, black/white list, and memory of menu selection.
Comment #10
dboulet commentedMarked #534634: Use Default menu for content as the source Menu as a duplicate.
Comment #11
xurizaemonLooks like this will be fixed with #556552: Menu weights, black/white list, and memory of menu selection