Project:Menu Breadcrumb
Version:6.x-1.1
Component:Code
Category:feature request
Priority:normal
Assigned:Unassigned
Status:closed (won't fix)

Issue Summary

Sometimes different menu entries are used for a single path. In these cases, Menu Breadcrumb select one of these. This patch adds a dropdown box to select the default menu that will be used for breadcrumb. Navigation menu items are excluded by this method to preserve breadcrumb on administration pages. A screenshot is attached.

Note: "Use menu the page belongs to..." should be enabled.

AttachmentSize
default_custom_menu.jpg22.37 KB
menu_breadcrumb_custom_menu.patch2.02 KB

Comments

#1

Status:needs review» reviewed & tested by the community

+5 for this patch for me - in my opinion, this module is unusable without this patch applied. Please can somebody commit this.

#2

+1

#3

ty so much, just wanted to code that myself

#4

Status:reviewed & tested by the community» needs work

This feature would be very useful, especially for multilingual sites with separate menus for each language. Patch needs work...

#5

dboulet, can you please clarify what needs work about the above patch? Seems you mean it doesn't handle per-language menus appropriately - can you describe the issue you see in that case?

#6

Sorry xurizaemon, I should have described the work that was needed in more detail--now, over 2 months later, I don't even recall exactly what the issue was.

I'm pretty sure that the problem wasn't with using multi-lingual variables, I think that it was a problem with the logic that decides when to use the default menu. Using the last patch, the default menu will always be chosen--whether the current menu item belongs to that menu or not. Seems to me that the default should only be used as a fallback when a conflict is detected, when there exists more than one menu item that points to the current path. Does that make sense, or have I misunderstood the logic behind the patch?

#7

The CVS version already does this :)

#8

AttachmentSize
menu.png 30.09 KB

#9

A black list/white list option, though a nice feature, is not exactly what we are after. I was thinking about this some more, and what we really need to to give each menu a weight so that they can be given an order of preference, as suggested by jweowu in #556552: Menu weights, black/white list, and memory of menu selection.

#10

#11

Status:needs work» closed (won't fix)

Looks like this will be fixed with #556552: Menu weights, black/white list, and memory of menu selection