Posted by mikey_p on January 26, 2009 at 7:37pm
8 followers
| Project: | Drupal core |
| Version: | 7.x-dev |
| Component: | documentation |
| Category: | bug report |
| Priority: | critical |
| Assigned: | cwgordon7 |
| Status: | closed (fixed) |
| Issue tags: | Novice |
Issue Summary
In hook_search on line 98 there is:
foreach (module_invoke_all('ranking') as $var => $values) {There are at least 2 implementations of this hook in core, in node and comment modules.
Comments
#1
So yeah...we've had this hook undocumented since May 2008. Bumping to critical.
#2
Subscribe. :\
#3
Also? While we're documenting this, can we please change it to hook_search_ranking()? I can think of lots of things that might be ranked. And this would help alphabetize it with the other search hooks.
#4
#5
I'll document the hook. For the sake of neatness, I'll move the hook's renaming into a separate issue.
#6
For more info - see http://drupal.org/node/145242
#7
Hint: This is currently a node.module specific hook, and not search.module.
#394182: DBTNG search.module would help to make this generic, maybe something like hook_search_ranking_$type.
#8
Pinged cwgordon7 by email to find out status of this.
#9
Here's a patch.
#10
Very nice ;)
Is there an issue to change the name somewhere else? Both of the other issue linked seem to go in other directions.
#11
My *idea* was to move this to search.module and make it more generic, something like hook_search_$type_ranking as it is currently limited to the node search. But the search.module DBTNGify patch is still not commited and I'm not sure if there is time to do this before code freeze.
#12
Excellent work!! :D
Committed to HEAD. Marking down to 6.x. Note that this can be committed to contributions/docs/hooks by anyone with CVS access.
#13
Doesn't make much sense to port this to 6.x because the hook doesn't exist there. :)
#14
Automatically closed -- issue fixed for 2 weeks with no activity.