Enabling Single Line Formatter

JamesAn - January 26, 2009 - 23:30
Project:Addresses
Version:6.x-1.05
Component:Code
Category:bug report
Priority:critical
Assigned:Unassigned
Status:needs work
Description

After much frustration, I've narrowed down a typo in the address module's theme_hook that prevent the single line format from displaying properly.

I'll generate a patch once I clean up my files. Around line 300:

    // Shows addresses using a single line
    'addresses_address_singleline' => array(

should be:
    // Shows addresses using a single line
    'addresses_singleline' => array(

#1

JamesAn - January 26, 2009 - 23:42

One more area that needs to be modified so that addresses_cck can do single line display. Uncomment lines 75 to 80:

//     'single_line' => array(
//       'label'           => t('Single Line'),
//       'arguments'       => array('element'),
//       'multiple values' => CONTENT_HANDLE_CORE,
//       'field types'     => array('addresses_cck'),
//     ),

becomes
    'single_line' => array(
      'label'           => t('Single Line'),
      'arguments'       => array('element'),
      'multiple values' => CONTENT_HANDLE_CORE,
      'field types'     => array('addresses_cck'),
    ),

I'll roll these two changes into a patch for the 1.05 version.

#2

JamesAn - January 26, 2009 - 23:56
Status:active» needs review

Here's the two changes to re-enable the single line formatter.

AttachmentSize
addresses_single_line.patch 1.76 KB

#3

JamesAn - January 26, 2009 - 23:58
Title:Address singleline theme function misspelled» Enabling Single Line Formatter

Let's make the title more appropriate.

#4

kdebaas - June 8, 2009 - 18:25
Status:needs review» needs work

In the single line formatter display, the country field is returned as two-letter code, and the additional field is missing. It also does not respect field order (although the ability to set field order is a bit buggy still anyway).

 
 

Drupal is a registered trademark of Dries Buytaert.