I wanted to customize the loading graphic for our site and the following changes made this easier for me.

Note:
*I used $loading.length instead of $loading.size() as I think it may be faster since it's not a function (correct me if I'm wrong).
*setting initial display of #popups-loading to display:none in css and then switching to block in js after applying top and left hides the repositioning.

CommentFileSizeAuthor
popups.loading.theme_.patch1.34 KBsirkitree

Comments

starbow’s picture

starbow commented
Status: Active » Needs review

Interesting. I bet other people would like to use this too. Looks fine with a quick look, but I will need to do some testing. If anyone else reading this wants to test it, let me know what you find.

starbow’s picture

starbow commented
Status: Needs review » Needs work

Hmm, I really like this idea, but it doesn't seem to work. width and height are 0 for blocks with display:none.
I am reworking it, but curious if it ever worked for you?

starbow’s picture

starbow commented

Ah, I get it. It works, just not with the default html.

starbow’s picture

starbow commented
Status: Needs work » Fixed

A version of this has been checked into head and will be part of 1.2 alpha2

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.