PHP notices / code clean-up

Still seeing:

# notice: Undefined variable: trail_raw in /Users/amorton/Sites/rfy/sites/all/modules/menutrails/menutrails.module on line 344.

I'd go for something even simpler like this.

found another one:

# notice: Undefined variable: menu in /sites/all/modules/menutrails/menutrails.module on line 89.

That one is kind of puzzling:

/**
 * Set Breadcrumbs based on active menu trail.
 */
function menutrails_get_breadcrumbs() {
  $item = menu_get_item();
  if (!$menu) {
    // Give first priority to the selected menu.
    $menu = variable_get('menutrails_menu', FALSE);
    if (!$menu) {
      $menu = db_result(db_query("SELECT menu_name FROM {menu_links} WHERE link_path = '%s' AND module = 'menu'", $item['href']));
    }
  }
  $tree = menu_tree_page_data($menu);
  $crumbs = array(l(t('Home'), '<front>'));
  _menutrails_recurse_crumbs($tree, $item, $crumbs);

  return $crumbs;
}

I guess that should be if (!$item)...?

Finished this up:

	•	notice: Undefined index: 105 in /Library/WebServer/Documents/rfy_hacking/sites/all/modules/menutrails/menutrails.module on line 280.

Now seeing:

notice: Undefined variable: menu in /Library/WebServer/Documents/rfy_hacking/sites/all/modules/menutrails/menutrails.module on line 96.

oh, yeah much better.