Fields appear outside fieldsets.
eliza411 - January 27, 2009 - 06:38
| Project: | Workflow Fields |
| Version: | 5.x-1.x-dev |
| Component: | Code |
| Category: | bug report |
| Priority: | normal |
| Assigned: | kratib |
| Status: | needs review |
Description
I'm having trouble with Workflow Fields 5.x-1.2 and CCK 5.x-1.x-dev.
It appears that fields which are only set to Visible with Workflow Fields are ordered by the field weight and the fieldset weight and placement is not taken into account, while fields set to Visible and Editable DO appear inside their proper fieldset.
I've attached screenshots of the view of a node and its edit page to help illustrate the problem.
Any help you can provide would be greatly appreciated!
| Attachment | Size |
|---|---|
| view-node.png | 32.5 KB |
| node-edit.png | 48.48 KB |
#1
Sorry, I uploaded the node add screen named node-edit.jpg
Here's the actual node edit screen, named node-edit2.
#2
Thanks for the report. It's a long-standing issue that really needs resolution, I guess I'll work on it this weekend or next week.
#3
Super! If you need help with testing or documenting, I'll be glad to do what I can.
#4
This is fixed in the latest dev version of D6 branch. Do you still need it in D5 or have you already upgraded?
#5
#6
Unfortunately, upgrading wasn't an option for this project. :( We had to come up with a fix for 5, and I've been waiting to respond to until I can include a patch file. It's not a properly generalized solution, though.
When I get the patch, I'll post it, but there's no immediate need.
Thank you so much for following up. I know I'll be using this in 6, too, and I'll be glad to have the fix there!
#7
This is the patch Eliza411 mentioned.
--
If anyone needs this to work in Drupal 5 here is a patch against the D5 branch showing how we did it. It requires changing the weight of workflow_fields to 9 so that fieldgroups has already done its thing before we modify the form. I'm sure there is a better way to do this without changing the weight but I don't know what it is.
This patch also makes it so that the fields cannot be seen even when viewing source which is very nice for people who need to keep the hidden fields from people who are actively snooping.
I only tested this with text fields and radio buttons so other widgets may cause trouble.
#8
Thanks for the patch. I'll take a look at it, and compare it with the approach I used to fix the issue in D6. I'll commit a fix either way soon.
#9
Kritib, will this patch be committed?
Thanks for your work!
#10
This issue is not really resolved. The fieldsets for Menu, Revision and Path settings and so on are still mixed with Fields that are only viewable, but not editable:
If Users that can edit the node have rights for those settings, it looks very messy.