I'm having trouble with Workflow Fields 5.x-1.2 and CCK 5.x-1.x-dev.
It appears that fields which are only set to Visible with Workflow Fields are ordered by the field weight and the fieldset weight and placement is not taken into account, while fields set to Visible and Editable DO appear inside their proper fieldset.
I've attached screenshots of the view of a node and its edit page to help illustrate the problem.
Any help you can provide would be greatly appreciated!
| Comment | File | Size | Author |
|---|---|---|---|
| #10 | Screenshot-node-formular.png | 41.04 KB | eigentor |
| #7 | better_cck_handling.patch | 3.98 KB | halstead |
| #1 | node-edit2.png | 39.17 KB | eliza411 |
| node-edit.png | 48.48 KB | eliza411 | |
| view-node.png | 32.5 KB | eliza411 |
Comments
Comment #1
eliza411 commentedSorry, I uploaded the node add screen named node-edit.jpg
Here's the actual node edit screen, named node-edit2.
Comment #2
infojunkieThanks for the report. It's a long-standing issue that really needs resolution, I guess I'll work on it this weekend or next week.
Comment #3
eliza411 commentedSuper! If you need help with testing or documenting, I'll be glad to do what I can.
Comment #4
infojunkieThis is fixed in the latest dev version of D6 branch. Do you still need it in D5 or have you already upgraded?
Comment #5
infojunkieComment #6
eliza411 commentedUnfortunately, upgrading wasn't an option for this project. :( We had to come up with a fix for 5, and I've been waiting to respond to until I can include a patch file. It's not a properly generalized solution, though.
When I get the patch, I'll post it, but there's no immediate need.
Thank you so much for following up. I know I'll be using this in 6, too, and I'll be glad to have the fix there!
Comment #7
halstead commentedThis is the patch Eliza411 mentioned.
--
If anyone needs this to work in Drupal 5 here is a patch against the D5 branch showing how we did it. It requires changing the weight of workflow_fields to 9 so that fieldgroups has already done its thing before we modify the form. I'm sure there is a better way to do this without changing the weight but I don't know what it is.
This patch also makes it so that the fields cannot be seen even when viewing source which is very nice for people who need to keep the hidden fields from people who are actively snooping.
I only tested this with text fields and radio buttons so other widgets may cause trouble.
Comment #8
infojunkieThanks for the patch. I'll take a look at it, and compare it with the approach I used to fix the issue in D6. I'll commit a fix either way soon.
Comment #9
basby commentedKritib, will this patch be committed?
Thanks for your work!
Comment #10
eigentor commentedThis issue is not really resolved. The fieldsets for Menu, Revision and Path settings and so on are still mixed with Fields that are only viewable, but not editable:
If Users that can edit the node have rights for those settings, it looks very messy.
Comment #11
adshill commentedI can confirm this issue still exists.
Comment #12
infojunkieI was able to reproduce this on D6. @adshill, which version of Drupal are you running?
Until I fix it, a temporary workaround is to hack the module weight of workflow_fields to be higher than fieldgroup's weight (which seems to be 9 by default). This can be done by setting the value of the
weightfield of database tablesystemto 10 wheresystem.name = 'workflow_fields'.Comment #13
infojunkieFixed in the latest dev. Someone please try it 12 hours from now.
I haven't been giving support for this module for the past year. Sorry about that and thanks for your patience.
Comment #14
adshill commentedHi Kratib,
I'm on D6. I'm using fieldgroup tabs module so the viewable fields appear outside the tabs which is not good!
I've fixed it using css display:none as I actually don't want them to appear at all in my case but I will do my best to test your fix at some point. Thanks for your help as this is a GREAT module!
Adam
Comment #16
rconstantine commentedWith the latest dev, this still doesn't work with fieldgroup tabs, which are a kind of fieldgroup.