Use theme('username',...) function instead of author name

I also want this function and found a solution. Here is a simple patch that works for me.

The latest dev should have an overrideable theme_quote which you can use to get this done.

Cheers,
-K

I ran into the same problem. The following patch does the same thing as #2 but paste the name without a hyperlink to the user's page. This is consistent with how quote module works for usernames.

While I could use theme_quote to do this, if this small change is made, then everyone that uses the realname module can automatically have the username turned into the real user name. This would be quite convenient compared to having to write a theme function. RealName is a rather popular module, so there are lots of people who would benefit from this change.

Also, it's my understanding that it's best practice to display usernames using a theme function. For an example, look at this issue.

This patch works really good, thanks!

Applied patch in #5 to 6.x-1.1-beta2 version of quote. Working Great.

Thank you

Hi. #5 seems to work quite nicely for comment quotes but not for node quotes. If I click the Quote link on a story post on my sandbox site I get [quote=MyUserName]Quoted node material.[/quote] but if I click the quote link on a comment I get [quote=MyRealName]Quoted comment material.[/quote].

This is a big problem for me because I'm trying to use the Quote module (with patch at http://drupal.org/node/496910#comment-2564416) with the 6.x-2.x Node Comments module and essentially all quoted material is taken from nodes and nome from traditional Drupal comments.

I wish I knew how to fix this myself but I'm not all that great with code. Anyone?

For clarification: On my sandbox site I tested the quote module with patch in #5 on regular comments without the Node Comments module installed with the same result so the problem is definitely not with the Node Comments module or with the patch (http://drupal.org/node/496910#comment-2564416) I mentioned earlier.

The module in #10 did not work for me.

On admin/user/realname-ext/general I get: warning: call_user_func_array() [function.call-user-func-array]: First argument is expected to be a valid callback, 'realname_admin_settings' was given in /includes/form.inc on line 372.

On admin/user/realname-ext I get no errors or warnings but if I check "OVERRIDE AUTHOR USERNAME IN QUOTE" and click "Save configuration" I get:
Fatal error: Call to undefined function dpm() in /sites/all/modules/realname_ext/realname_ext.admin.inc on line 80

What I would really love is a Patch from that comment you referred to (http://drupal.org/node/268510#comment-2453638) because I'm not all that good with code and I'm not sure how to proceed with the information in that comment.

Thanks for the module, it works. A couple of observations though:

1) When I saved the settings with override for quote module on the realname extension page I got a message that said "Theme registry rebuilded" but should have said "The theme registry has been rebuilt".

2) I noticed that when you quote someone, you get [quote=username]quote material[/quote] but when the comment is saved and viewed it says RealName wrote "quote material". I think it should work in a way that it would print [quote=Real Name]quote material[/quote] and the viewed comments should be Real Name wrote "quoted material". The purpose of RealName (as I see it) is to not show usernames to the public (and logged in users) but to use the real names of users on posts, comments, profiles and paths. That way if a user changes his/her username it would be for his/her preference but the public wouldn't really ever notice. A user should not change his/her Real Name unless one gets married or otherwise actually has his/her real-world-name changed.

I see that your module doesn't really change the way quotes are handled upon comment submission but rather the way quotes are displayed upon comment/node view so (2) is not really a part of your module but I thought I'd add my two cents. Maybe the method you mentioned, using [quote=uid] would be technically best and most flexible but for the end user it would be least confusing and most consistent to use [quote=Real Name].

1) That's not really a problem of course so I don't think I'll bother changing it. Just thought I'd point it out ;-)

2)
a) I didn't mean to say that [quote=uid] was worse than [quote=username], I meant that [quote=Real Name] would be more consistent and less confusing for users than the other two. I say that because I (and a lot of people, I think) use RealName so that I don't have to display usernames and uids on pages, posts, comments, profiles, paths or whatever.

b) I know that writing manual quotes is easy and really not a problem.

Im not saying this is a huge problem. What I mean is that given a choice, I would choose not to display usernames or uid anywhere on my sites except for necessary administrative purposes. That is the reason I use RealName ;-)

Anyway, if you decide to go ahead and write your own quote-ish module, I'd love to help out. I'm not that much help with the code but I have some ideas and opinions I could share if you think it would help.

Thanks again for the RealName Extension module, it solves 96.4% of the problem for me ;-)

Hi! I finally got around to checking your update out, sorry for not doing so sooner. It works wonderfully with standard comments but not with nodecomments and appropriately patched quote module. When using this method it always inserts [quote=Username] to the textarea, no matter what settings are set.

I think you should start a project for your realname-ext module so we can discuss it there. I'd also love to hear more about other ideas you have about that module. I could probably help (and lots of other people of course) with feature development for that module.

Thanks again for all your work!

A bit about that nodecomment quote patch: It doesn't do selection quoting yet, but that's an awesome feature that I hope they'll support soon. It's still a good patch.

And even more off-topic: I think nodecomments are a great idea. I personally don't really like the idea of trying to create a Drupal-based forum that's almost exactly like PHPBB (drubb) because I think that with Drupal and CCK and NodeComment you can create far better forums that are much more user-friendly (especially in wysiwyg and attachment handling) than PHPBB. I think supporting BBCode is a little like supporting Internet Explorer; we may have to support it because a lot of people use it but we don't have to like it and we don't have to encourage people to use it.

No worries, the [quote=Username]-displayed-as-Realname-Wrote method provided by your module will do for now, until a better solution is found. And by the way I totally understand and agree. I don't really get why Zen seem not to want to use theme('username',...) (as seen in #3) in the Quote Module, it seems like a win-win solution, although I'm no code ninja and I don't know if there are performance problems or something like that with the theme('username,...) approach.

subscribe

A new attemt to get the usernames themed. The patch comes from code from manager of RealName module -> http://drupal.org/node/268510#comment-2453638

The patch in #26 is really simple and is basicly the same as http://drupal.org/node/364871#comment-2474986 and http://drupal.org/node/268510#comment-2453638 have used. Thats why i mark this as RTBC.

Hello Magnus,

I'm not terribly taken with the idea of injecting the rendered output of theme_username into the textarea as per the RTBC'd patch. It defeats the very purpose of the function.

If something like this needs to be done, it will either involve user_load calls in the filter process stage, or alternatively, require a variant of [quote] which links to the comment's CID. The latter has the added advantage of allowing us to link to the quote's origin, besides enabling us to load the comment to retrieve the UID we are looking for.

-K

The patch in #26 fixed the issue for me. Thanks!

If #911952: Link to quoted post goes in, this can be resolved cleanly.

-K

I've created a patch for 7.x-1.x version. Please review.

Thanks.

Thanks, #31 works

Committed slightly modified patch. Thanks guys.

-K