Drupal 5.15 ubercart 5.x-1.7

I am setting up Ubercart to assign roles for content access (for 1 year) upon completed payment using paypal.

I am seeing the payment go through and the role assigned but for 2 years.

From the Remote website:
01/26/2009
5:18:41 PM - Customer granted user role subscribers.
01/26/2009
5:18:41 PM - PayPal IPN reported a payment of x.xx USD.
01/26/2009
5:18:49 PM 6 Customer user role subscribers renewed.
01/26/2009
5:18:49 PM - Order created through website.

I set up a duplicate of the site on my local server.
IPN is not working for the local site (status was "pending") so I manually clicked that the order was complete.
As soon as I click "Complete", the role is assigned locally for 1 year.

From the local website:
01/27/2009
12:07:05 PM - Order created through website.
01/27/2009
12:28:11 PM 1 Customer granted user role subscribers.

Is the paypal duplicates issue not resolved, or could I have something set incorrectly?

CommentFileSizeAuthor
#1 365145.order_status_typo.1.x.patch668 bytescha0s

Comments

cha0s’s picture

cha0s commented
Status: Active » Needs review
StatusFileSize
new 365145.order_status_typo.1.x.patch668 bytes

I think I finally have some resolution for this... and the sad part is, it was only a typo! It's hard to reproduce this bug, it's very random (race conditions :/) but this condition should have eliminated it. Unfortunately we were checking $order->status instead of $order->order_status :P Here's a patch against 1.x, please try and tell me if it fixes your problem!

rszrama’s picture

rszrama commented
Status: Needs review » Fixed

Same typo existed in file downloads module. These were my bad. :-/

Committed.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.