In the message You've been outbid;

the [formatted-price] returns the price you have placed on the auction and not the new price. Thus the
Current High bid price: x = your last high bid value.

Is that correct, shouldn't this price be the new high bid price?

Fossie

Comments

fossie’s picture

fossie commented

Ok, I think I figured out why the price is wrong in the message:

the $params['node'] in the token_replace_multiple array has the old node information (with the bid prior to the uc_auction_insert_bid).
on line 883 drupal_mail uses the $node object with wrong information (version read before the insert has passed).

Do you think this can be the problem?

Fossie

fossie’s picture

fossie commented
Status: Active » Needs review

Problem can be solved, but it's not an elegant way to do; but it seems to work;

Around line: 880 : Within the if (variable_get('uc_auction_notify_outbid', TRUE..
{
// added because the node object doesn't know about the newly inserted high bid
$node->uc_auction['high_bid_amt'] = $form_state['values']['user_bid'];

Can someone test it?

HTH,
Fossie

Garrett Albright’s picture

Garrett Albright commented
Status: Needs review » Fixed

Done. Thanks for letting me know about the bug.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.