hi and thanks for a great module

just fyi-
was running the latest dev version, 6.x-1.x-dev of path redirect-
on a drupal 6.9 install that had never been upgraded from 5.x-
it was a fresh install

anyways-

upon installing the new dev version (jan 27 2009), (or the same with the beta i assume)-
then a new database update is triggered / required by the mod-

however, the update then throws the following msgs / errors-

user warning: You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near 'small) NOT NULL' at line 1 query: ALTER TABLE path_redirect CHANGE type `type` INT(small) NOT NULL in /.../includes/database.mysql-common.inc on line 520.

and

Update #5100
ALTER TABLE {path_redirect} CHANGE rid `rid` INT NOT NULL auto_increment
ALTER TABLE {path_redirect} CHANGE query `query` VARCHAR(255) DEFAULT NULL
ALTER TABLE {path_redirect} CHANGE fragment `fragment` VARCHAR(50) DEFAULT NULL
Failed: ALTER TABLE {path_redirect} CHANGE type `type` INT(small) NOT NULL

did a little digging... it seems that maybe mysql 5.1 does not like the syntax for the INT(small)...?

and / or it seems that for me at least, my path_redirect table already has / had a col type of: smallint(6) for 'type'.

so-
maybe this update is not needed / should not be triggered if you are not upgrading from 5.x to 6.x-
but just updating from 6.x to 6.x?

please advise and thanks...
and also see attached...

vincent, in buffalo

CommentFileSizeAuthor
path_redirect_5100.png22.95 KBbasicmagic.net

Comments

dave reid’s picture

Status: Active » Fixed

Ah thanks. I Made a typo: 'length' => 'small' should have been 'size' => 'small'. Not to worry too much, the update should not have actually changed anything, it's only really for users that updated from 5.x.

basicmagic.net’s picture

cool and thanks.
is there a way / suggested patch for this just because i have a lot of drupal 6 sites-

and the error msgs scare some of admins / clients when doing the necessary update for the module.

please advise and thanks again-
vincent, in buffalo

dave reid’s picture

I fixed the type in the 6.x-1.x version a couple days ago, so anyone who downloaded it after that time won't see any errors. There's no patch because nothing was actually changed in your database...everything is ok.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.