Hello Michele.

Can the images be used per language, if there is more than one active
language?
Same as with the text links?

Thanks.

CommentFileSizeAuthor
#7 advanced_forum.module.patch723 bytesjoostvdl

Comments

michelle’s picture

michelle
she/her
Primary language English
Location Wisconsin, USA
commented
Status: Active » Fixed

No, the translation system won't handle graphics. The only thing I can think of is you could write some code to change the AF image directory when the language changes.

Michelle

akis p’s picture

akis p commented

I cant see how this issue has been fixed?
I'm missing something here?

Cant somebody else suggest a solution if you can't ?
If so why don't you set the status to active?

Im not a dev. and this option can by handy on local drupal support communities

Thanks.

michelle’s picture

michelle
she/her
Primary language English
Location Wisconsin, USA
commented

It's fixed because I answered your question. If you want to ask a question of the community in general, use the forums. Issue queues are for issues.

Michelle

akis p’s picture

akis p commented

Michele i can't translate your last reply.

The only thing I can think of is you could write some code to change the AF image directory when the language changes.

Can this bee done?

Of topic
You have far more experience than me, and you can tell
were the answers are given.
By your opinion does the drupal.org forum stands a comparison with the issue queue at the present?

michelle’s picture

michelle
she/her
Primary language English
Location Wisconsin, USA
commented

AFAIK, it can be done. I wouldn't have suggested it otherwise.

I have no idea what your OT question means.

Michelle

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

joostvdl’s picture

joostvdl commented
Status: Closed (fixed) » Needs review
StatusFileSize
new advanced_forum.module.patch723 bytes

I created a patch that adds the language prefix to the $image_path in the function advanced_forum_path_to_images if a directory with the name of the language_prefix does exist. It does this as a final step so all previous steps needed to determine the correct path are still in place.

michelle’s picture

michelle
she/her
Primary language English
Location Wisconsin, USA
commented
Version: 6.x-1.0-beta1 » 6.x-1.x-dev

This looks simple enough and unlikely to break anything so should be ok to get in even at this late point. I'll add it next time I work on AF.

Thanks,

Michelle

michelle’s picture

michelle
she/her
Primary language English
Location Wisconsin, USA
commented
Status: Needs review » Fixed

Committed. I haven't tested this outside of making sure it doesn't break the normal usage because I don't have any multi language sites so I'm just going to take your word for it that it works.

Thanks,

Michelle

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

akis p’s picture

akis p commented
Version: 6.x-1.x-dev » 6.x-1.1
Status: Closed (fixed) » Active

This was working in the beta versions.

Its not working in current stable version.
If there were broken links for the images shouldn't be there a hint?
like plain links or something?

michelle’s picture

michelle
she/her
Primary language English
Location Wisconsin, USA
commented

@panas: If you have this option turned on, you need to provide images. If you don't have image, turn it off. Beyond that, I'm not understanding the problem here. I don't have a multi lingual site so no way to test but I haven't had any other complaints since I committed it over 3 months ago.

If you're saying there's a bug in it, I need more specifics. If you're asking for it to do something it's not meant to do, then that's a won't fix as I'm not putting any more energy into 1.x.

Michelle

michelle’s picture

michelle
she/her
Primary language English
Location Wisconsin, USA
commented
Status: Active » Closed (fixed)

No more info provided. Closing.

Michelle

Sinan Erdem’s picture

Sinan Erdem commented

About Comment #7, where should I put the image directory? Directly under styles folder or inside the images folder?