As it is possible to note on the screen shot, the theme icon covers part of the graphic.

Comments

brianV’s picture

Version: 6.9 » 7.x-dev
avpaderno’s picture

Title: Site off-line theme icon is too big » Default site logo covers part of the graphic when there isn't a left-side bar

I am changing the title to make the issue more generic. The problem appears also in a 404 page, when the left-side column is not used.
If the default logo would be some pixels less in height, the problem would not exist.

jerdiggity’s picture

Title: Default site logo covers part of the graphic when there isn't a left-side bar » Default site logo disappears after changing colors of Garland theme
Priority: Normal » Critical
Status: Active » Needs review
Issue tags: +Logo, +#d7ux, +druplicon
StatusFileSize
new637 bytes
new42.85 KB
new19.07 KB

Changing the title again to make it more specific; also upgrading priority to critical.

This issue is not solely occurring because of changes in page size, etc. In fact I believe the problem lies within the core color.module (although I left this issue's component as Garland theme because I'd like a second opinion).

While using Garland, if you change the color scheme to anything other than Blue Lagoon then the logo disappears altogether and is replaced with the site name (please see the first pic).

However after playing around with the code a little bit I discovered that in the color.module file, if the following (at ≈ line 305):

variable_set('color_' . $theme . '_logo', $paths['target'] . 'logo.png');

were changed to this:

variable_set('color_' . $theme . '_logo', $paths['source'] . 'logo.png');

then at least a logo starts to appear -- the down-side is that the logo's color scheme (well, actually the logo itself) does not change to match the rest of the theme. It appears to be reusing the Blue Lagoon logo regardless of the selected color scheme (see the second pic).

I also attached a patch for the above code changes, but even with that change applied, a new logo still needs to be rendered. (FTR, test was done using FF so it's not an IE/png issue...)

Status: Needs review » Needs work

The last submitted patch failed testing.

avpaderno’s picture

Rather than making the issue more specific, you changed the topic. What you report is a completely different issue, which needs a separate report.

avpaderno’s picture

Title: Default site logo disappears after changing colors of Garland theme » Default site logo covers part of the graphic when there isn't a left-side bar
Status: Needs work » Active

I am changing the metadata to the original one. Please open a different report for the issue you noticed.

jerdiggity’s picture

Priority: Critical » Normal
Issue tags: -Logo, -#d7ux, -druplicon

My apologies.

jerdiggity’s picture

Oops... my apologies again (looks like you beat me to it.)

:)

avpaderno’s picture

There is nothing to apologize for; all is returned as it was before, and nothing is lost. :-)

Jeff Burnz’s picture

Status: Active » Closed (duplicate)