naming convention

askibinski - January 29, 2009 - 10:22
Project:SEO Checklist
Version:6.x-1.0-beta2
Component:Code
Category:task
Priority:normal
Assigned:Volacci
Status:closed
Description

This module uses uppercase function names, filenames and paths.

Please use seo_checklist or seochecklist instead of SEOChecklist

See drupal coding standards:
http://drupal.org/coding-standards

Also, the there are issues with the links to your external files on Volacci.com... (for one, the path to the jpg is broken)

#1

kscheirer - January 29, 2009 - 19:56

yes, please settle on a standard naming convention. the folder and project are named seo_checklist, but your files and functions start with SEOChecklist. There should be no variation here, I would suggest settling on one of the 2 options for project, folder, file, and function names.

#2

Volacci - February 7, 2009 - 16:57
Assigned to:Anonymous» Volacci

OK. Good point. I'll work on this for the next release.

#3

DamienMcKenna - February 15, 2009 - 21:17

FYI, due to this issue it is not possible to (cleanly) load seo_checklist using an installation profile, you have to rename the directory to exactly "SEOChecklist" (case sensitive on OSX or other UNIXes) otherwise you get colorful error messages.

#4

Volacci - February 19, 2009 - 12:35
Status:active» fixed

This is now fixed in Beta 3. I'll upload it as soon as possible.

#5

System Message - March 5, 2009 - 12:40
Status:fixed» closed

Automatically closed -- issue fixed for 2 weeks with no activity.

 
 

Drupal is a registered trademark of Dries Buytaert.