Download & Extend
SEO Checklist » Issues

naming convention

Posted by askibinski on January 29, 2009 at 10:22am
Project:SEO Checklist
Version:6.x-1.0-beta2
Component:Code
Category:task
Priority:normal
Assigned:Ben Finklea
Status:closed (fixed)

Issue Summary

This module uses uppercase function names, filenames and paths.

Please use seo_checklist or seochecklist instead of SEOChecklist

See drupal coding standards:
http://drupal.org/coding-standards

Also, the there are issues with the links to your external files on Volacci.com... (for one, the path to the jpg is broken)

Login or register to post comments

Comments

#1

Posted by kscheirer on January 29, 2009 at 7:56pm

yes, please settle on a standard naming convention. the folder and project are named seo_checklist, but your files and functions start with SEOChecklist. There should be no variation here, I would suggest settling on one of the 2 options for project, folder, file, and function names.

#2

Posted by Ben Finklea on February 7, 2009 at 4:57pm
Assigned to:Anonymous» Ben Finklea

OK. Good point. I'll work on this for the next release.

#3

Posted by DamienMcKenna on February 15, 2009 at 9:17pm

FYI, due to this issue it is not possible to (cleanly) load seo_checklist using an installation profile, you have to rename the directory to exactly "SEOChecklist" (case sensitive on OSX or other UNIXes) otherwise you get colorful error messages.

#4

Posted by Ben Finklea on February 19, 2009 at 12:35pm
Status:active» fixed

This is now fixed in Beta 3. I'll upload it as soon as possible.

#5

Posted by System Message on March 5, 2009 at 12:40pm
Status:fixed» closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

nobody click here