Hi,
this module seems really promising!

I applied the patch from here: #349294: Messy code (Code clean-up)
which applied cleanly.

One issue though - when I change settings for linked groups at /admin/settings/mailman_manager/edit/1 (for instance 'Auto-subscribe' or 'Mailing List visibility' and click Save), I get the following error:

Fatal error: Call to undefined function sprint_r() in /Applications/MAMP/htdocs/wewantmore/sites/all/modules/mailman_groups/mailman_groups.module on line 161

If I change the options directly in the {mailman_groups} table of the DB (for instance changing 'sync' from 0 to 1) it seems to work :) I hope this is slightly helpful in tracking down the problem.

Is anyone else able to reproduce this issue?

Comments

andy inman’s picture

andy inman commented
Priority: Normal » Critical

Hi, sorry for not getting in here to check issues until now...

sprint_r is a debug function, so it sounds like there's some debug code that didn't get removed. I'll take a look and aim to finally get a version uploaded here.

andy inman’s picture

andy inman commented
Status: Active » Fixed

Confirmed, the "cleanup patch" http://drupal.org/node/349294 removes some debug code, including the definition of sprint_r(), but leaves in a couple of debug lines, one of which calls sprint_r() - line #161

Line 158:

  $dbmsg = sprintf('gid: %d -- ', $gid) . sprint_r($vars);

Strange, as the patch was reported as tested. I will fix it before making the release here.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.