Activity time limiter not working [#366178]

The activity time limiter mentioned in the module's settings page is not functional. Despite choosing any time limit, the module will still record and display all activity, even duplicate entries.

The problem is in activity_insert(), where a check is attempted on an integer from a column that doesn't exist.

Attached is a patch to fix this problem.

(Note this is a problem in version 5.x-3.0-beta2 and may have already been fixed in the development version.)

Comment	File	Size	Author
	activity_time_limit_fix.patch	960 bytes	remi

Comments

Comment #1

jaydub commented 20 February 2009 at 07:48

The current code should work without requiring the COUNT(*) function needing an alias.

What version of PHP are you using?

You can add in this as a test:

function activity_insert($uid, $module, $type, $operation, $data, $target_users_roles) {
  // check time limit, ignore activity if within the limit
  $result = db_query("SELECT COUNT(*) FROM {activity} WHERE uid = %d AND module = '%s' AND type = '%s' AND operation = '%s' AND data = '%s' AND created >= %d", $uid, $module, $type, $operation, serialize($data), (time() - variable_get('activity_time_limit', 30)));

  // Debug test
  var_dump(db_fetch_object($result));

  if (db_fetch_object($result)->count != 0) {
    return FALSE;
  }

You should see the PHP debug dump for the query object with a single object attribute of 'count' with a numeric value.

Can you do this and return the result here along with the details of your setup?