Well, that´s it. This dev 6 version isn´t compatible with last D6.
Please upgrade it, this module is terrific!
Thanks!

CommentFileSizeAuthor
#30 comment_perm-D6-30.patch14.59 KBstborchert
#21 comment_perm-d6.patch10.17 KBomerida
#19 comment_perm-d6.patch11.01 KBjohn morahan
#17 comment_perm.zip9.06 KBlivido
#10 comment_perm_d6.patch3.67 KBraspberryman
#2 comment_perm_d6.patch3.03 KBblack silence

Comments

matt2000’s picture

matt2000 commented

Subscribing. I will probably be working on solving this myself this week if another solution does not appear.

black silence’s picture

black silence commented
StatusFileSize
new comment_perm_d6.patch3.03 KB

*appear*

- makes this 'd6 version' compatible with d6 (i think it was just a copied d5 version)
- integrates with quote module if enabled, hides quote link if comment link is hidden

Rosamunda’s picture

Rosamunda commented
Status: Active » Needs work

I´ve installed the patched version.
So far:
When I enter the "Comment Permissions" link inside admin, I access the page, with this error:

warning: Invalid argument supplied for foreach() in ...\includes\form.inc on line 1192.

function form_type_checkboxes_value($form, $edit = FALSE) {
  if ($edit === FALSE) {
    $value = array();
    $form += array('#default_value' => array());
THIS IS THE 1192 LINE =======>   foreach ($form['#default_value'] as $key) {
      $value[$key] = 1;
    }
    return $value;
  }
  elseif (!isset($edit)) {
    return array();
  }
}

Otherwise that error, it seems to be working.

Rosamunda’s picture

Rosamunda commented

I´ve tried reinstalling the module, but the problem is still there.

Rosamunda’s picture

Rosamunda commented

This module is so important, because permissions are globally treated in Drupal.

black silence’s picture

black silence commented

i had this error, too. but only the first time, before i enabled some comment permissions

Rosamunda’s picture

Rosamunda commented

Any news about this?

Rosamunda’s picture

Rosamunda commented

It won´t work with Drupal 6.10 either.

Rosamunda’s picture

Rosamunda commented
Priority: Normal » Critical

As it´s not compatible with core 6.x version, I´ll change this to critical.

raspberryman’s picture

raspberryman commented
Title: Not compatible with Drupal 6.9 » Improve compatibility with Drupal 6.x
Status: Needs work » Needs review
StatusFileSize
new comment_perm_d6.patch3.67 KB

This patch gets the module working on 6.10. Rosamunda - I didn't investigate your error message, but on first glance I did not see it. So this patch may or may not fix it.

Rosamunda’s picture

Rosamunda commented

I´ll try it out. Thanks Tony!

black silence’s picture

black silence commented

i don't see a difference to my patch from #2

as i said, that error message appeared only the first time, when i had no permissions set. after doing that, everything was fine and worked as expected

the project where i used this module is finished for me, so i will not try to fix this

Rosamunda’s picture

Rosamunda commented

Any idea of why a second install with the patched version, on a fresh D.6.10 could make this module incompatible with D 6.10 again?
I´ve patched the same way as I did in localhost (and there it worked)...
Thanks for your help!!

Rosamunda

Rosamunda’s picture

Rosamunda commented

Sorry, my bad, I forgot to patch the .info file.
Have to stop drinking too much coffee you know.
Sorry :)

EvanDonovan’s picture

EvanDonovan commented

Patch in #10 works except for on the .info file. I got HUNK #1 OF 1 FAILED on that. However, it looks like the change to dependencies[] was already in the module.

EvanDonovan’s picture

EvanDonovan commented

This issue is still, of course, critical. If the maintainer is out there, can they please commit a patch for this?

livido’s picture

livido commented
StatusFileSize
new comment_perm.zip9.06 KB

Here is the version 6.

I added also permission for "edit own conment".

Rosamunda’s picture

Rosamunda commented

Thanks! I´ll check it out!

john morahan’s picture

john morahan commented
StatusFileSize
new comment_perm-d6.patch11.01 KB

Here's livido's version as a patch, with some minor coding style fixes and a fix for the form error.

The maintainer seems to be awol though...?

bratsun’s picture

bratsun commented

I receive

Fatal error: Cannot use object of type stdClass as array in /var/www/drupalbase/htdocs/sites/all/modules/comment_perm/comment_perm/comment_perm.module on line 162

with the core 6.13

but the idea of the module really rocks.

to overcome the error with little time spent on the task, i decided to alter templates with following conditions

if (in_array('Client', array_values($user->roles)) && $node->type=='blog') {

do smth

}

for ex, u can add extra class to wrapper and hide the links. not a pretty solution, but still it works.

all the best

omerida’s picture

omerida commented
StatusFileSize
new comment_perm-d6.patch10.17 KB

Patch in #19 didn't apply cleanly for me, got hung up on the .info file, here's a re-rollled patch that should apply without problem.

adam_b’s picture

adam_b commented

subscribing... I'd like a D6 version too

Rosamunda’s picture

Rosamunda commented

I´ve installed the patched version, and it works just as it should.
THANKS!!

lejonsson’s picture

lejonsson commented

Rosamunda,

Which patch works, the one in #21?

Rosamunda’s picture

Rosamunda commented

Yup. I´ve successfully tried #21.

himagarwal’s picture

himagarwal commented

I can't install this module. In the module page (admin/build/modules/list) it says:

This version is incompatible with the 6.14 version of Drupal core.

EvanDonovan’s picture

EvanDonovan commented

@himagarwal:

Did you apply the patch first?

@all:

Has anyone heard from the module maintainer recently? We should decide which version of the patch is RTBC, change issue status, and then if the maintainer doesn't respond within a week or so, we should petition to have a new maintainer for this module. I'm currently using the patched version of it (patch from #10, with a few modifications to make it apply), but I am not excited about the fact that there is no stable, maintained release (especially because the actual functionality is so useful).

I wish I had thought of it, but more granular comment permissions would have been great for Drupal 7. Oh well.

omerida’s picture

omerida commented

@EvanDonovan - we're using the D6 patch (#21) on production here and I'd be glad to help maintain a D6 version of the module. I have another patch, that I haven't submitted. How do we petition to have a new maintainer?

omerida’s picture

omerida commented

I created an issue here http://drupal.org/node/600332, so hopefully we'll have some movement.

stborchert’s picture

stborchert
he/him
Primary language German
commented
StatusFileSize
new comment_perm-D6-30.patch14.59 KB

I've updated the patch and fixed some minor issues (e.g. initial comment state is "read/write" instead of "disabled").

Patch is based on HEAD.

benshell’s picture

benshell commented
Status: Needs review » Fixed

I updated the D6 dev version with this patch, and some additional features (#489314: Comment without approval by role and #539844: Patch to add Comment on Own permission by content type). I'm sorry I haven't been more responsive as a maintainer. Since I started this a lot has changed for me personally. In particularly I'm now working for a different company that is much less supportive of open source. I'd be happy to have someone take over as maintainer.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.