Collapse modules on Permissions page

Works perfectly on a rather clean Drupal site with only few modules installed.

Unfortunately, this leads to a total browser freeze in Firefox 3 when there are plenty of roles and permissions.

This was a neat idea, but I've no time to work on this. And it seems that no one else is interested.

Committed attached patch to all branches.

A new development snapshot will be available within the next 12 hours. This improvement will be available in the next official release.

I absolutely see your point. Trust me, I really see it.

However, when you look at the code of that better_perms module (which I didn't even know before), then you'll see plenty of awkward and horrible manipulations of regular theme functionality. For something that can be done in a tiny fragment of the code.

I've seen similar nightmares in Util module before, which effectively lead to a comparable option in admin_menu to collapse package fieldsets on the modules page. Util's override required a theme function override, which effectively lead to Drupal core accounting for this special case (what happens to the modules page if the theme override is suddenly no longer available?). Which in turn - resulted in one of the most bizarre performance penalties in Drupal 6.

10 lines of code don't deserve a separate module. If I can make this functionality available to 50% of all Drupal users with a simple checkbox, then I see no reason to not do it.

In Util's case, admin_menu was able to provide the identical functionality - with 1 line of code (instead of 200+). Since then, people never ever had to install Util module again.

After all. Yes, my intention and vision for admin_menu always has been - as in: since Drupal 4.7.x - to ease, speed up, and optimize Drupal's administration. The new (and broken) menu system in Drupal 6 prevented us from advancing sooner. But my (our?) vision is still the same. We want to administer and build with Drupal. And unlike core, we still want to be able to do it after taking Drupal's modularity into account.

Therefore, I welcome any suggestions to improve Drupal's administrative usability within the Administration menu project. However, since I already know how people react to any improvement that is added, all new functionality will always be optional and disabled by default.

In the end, we need evolution.

+++ admin_menu.js	20 Feb 2010 00:57:47 -0000
@@ -62,6 +63,32 @@ Drupal.behaviors.adminMenuCollapseModule
+          // @todo Replace with .nextUntil() in jQuery 1.4.
+          $module.nextAll().each(function () {
+            var $row = $(this);
+            if ($row.is(':has(td.module)')) {
+              return false;
+            }
+            $row.toggleClass('element-hidden');
+          });

Actually, I'm just waiting for #653580: Upgrade to jQuery 1.4 to get into D7 [it definitely will] - to decrease this once more to a single line. ;)

For this reason, (as stated earlier in this issue) backporting to earlier versions of jQuery is not possible.

Powered by Dreditor.