AHAH enhancements

netaustin - January 30, 2009 - 05:20
Project:Comment Upload
Version:6.x-1.x-dev
Component:Code
Category:bug report
Priority:critical
Assigned:netaustin
Status:closed
Description

This patch reflects the AHAH philosophy of poll.module, as preached by chx. It works with and without project_issue and degrades fine without JS enabled.

AttachmentSize
fapi_like_poll.patch6.2 KB

#1

netaustin - January 30, 2009 - 06:22

use this one

AttachmentSize
new.patch 6.41 KB

#2

netaustin - January 30, 2009 - 06:52

trying again

AttachmentSize
new.patch 6.63 KB

#3

netaustin - January 30, 2009 - 07:19
Status:needs review» fixed

committed.

#4

Heine - February 12, 2009 - 07:58

Unfortunately this seems to cause #373146: 'Comment Field is required' when clicking the Attach. Should we roll this back?

#5

Heine - February 19, 2009 - 16:40
Status:fixed» active

Setting this back to active.

Would a rollback conflict with project_issue? I will test before doing anything of course, but a "Not likely" or "Yes, complete breakdown" is helpful.

#6

netaustin - June 8, 2009 - 23:01
Status:active» closed

Heine: we did eventually roll back to upload.module behavior, which worked much better once a couple minor issues were solved.

 
 

Drupal is a registered trademark of Dries Buytaert.