Project:Comment Upload
Version:6.x-1.x-dev
Component:Code
Category:bug report
Priority:critical
Assigned:netaustin
Status:closed (fixed)

Issue Summary

This patch reflects the AHAH philosophy of poll.module, as preached by chx. It works with and without project_issue and degrades fine without JS enabled.

AttachmentSize
fapi_like_poll.patch6.2 KB

Comments

#1

use this one

AttachmentSize
new.patch 6.41 KB

#2

trying again

AttachmentSize
new.patch 6.63 KB

#3

Status:needs review» fixed

committed.

#4

Unfortunately this seems to cause #373146: 'Comment Field is required' when clicking the Attach. Should we roll this back?

#5

Status:fixed» active

Setting this back to active.

Would a rollback conflict with project_issue? I will test before doing anything of course, but a "Not likely" or "Yes, complete breakdown" is helpful.

#6

Status:active» closed (fixed)

Heine: we did eventually roll back to upload.module behavior, which worked much better once a couple minor issues were solved.

nobody click here