Replace hook_help() hacks with a cleaner solution for the dynamic headers on issue views
dww - January 30, 2009 - 06:15
| Project: | Project issue tracking |
| Version: | 6.x-1.x-dev |
| Component: | User interface |
| Category: | task |
| Priority: | normal |
| Assigned: | dww |
| Status: | active |
| Issue tags: | 6.x-1.0 blocker, drupal.org redesign |
Description
To run on d.o, we can't have a PHP filter for the header for the default issue views, even though that'd be the easy way to have the nice little set of links across the top of the issue pages, and for #359130: Convert the "My projects" page to a view.
#1
Here's a start of a display plugin, and views sees it as a choice, but when I try to add it, I get JS errors and other badness. Not sure how to actually debug this.
#2
Whoops, I forgot about this issue when I submitted #406578: Replace hook_help() hacks with a cleaner solution for the dynamic headers on issue views ;)
The plan I listed there was:
- extend the attachment display plugin into a "Project issue header" subclass
- in this kind of attachment display, have the options I need to select what kinds of links you want
- in the display plugin's render() method, invoke the right function to generate the desired links
- fix the default issue views to use a properly configured attachment
- rip out the nasty inside project_issue_help()
I haven't messed with attachments yet, but this should hopefully be fairly straight forward...
Also, the fact we're using hook_help() is causing grief for the d.o redesign, we should make sure we have a real solution before the redesign launch...
#3
Tagging for #439958: Document issues left before 6.x official release
#4
Is the
hook_help()hack one we can live with for now, or is it still a 6.x-1.0 blocker?#5
It's pretty whack. I'd really like to replace it. It looks completely stupid on a lot of sites that have themes which don't just render the help text at the top of the page. The redesigned drupal.org theme, for example, does completely weird things with the help div. I've run into at least 2 other sites that had this problem, too...
#6
There might be a native solution for this in views via #510284: Header/footer/empty text pluggable, and merlinofchaos might even agree to backport that to Views2 since we need it on d.o. That'd be a lot better than what I proposed at #2...