Download & Extend
Comment Upload » Issues

Set weight to ? (Preview w/Quote module causes doubled text)

Posted by Heine on January 30, 2009 at 8:15am
Project:Comment Upload
Version:6.x-1.0-alpha4
Component:Code
Category:bug report
Priority:normal
Assigned:Unassigned
Status:active

Issue Summary

With the new AHAH code, weight 10 is no longer needed. Commit #167994 sets it back to 0.

Login or register to post comments

Comments

#1

Posted by Heine on February 3, 2009 at 10:16am
Title:Set weight to 0» Set weight to ?
Status:fixed» active

Reactivating as the following code is still in, and needs to run _after_ other modules.

<?php
  $build_form = form_builder('comment_form', $copy_form, $state);
  comment_upload_value_to_default($build_form, $form);
?>

#2

Posted by netaustin on February 4, 2009 at 2:14am

Setting the weight to 2 did the trick; that's what should be in the D6 branch.

#3

Posted by Heine on February 4, 2009 at 7:57am

If the weight is 2, there's no guarantee that project_issue runs after comment_upload as the execution order would then depend on the alphabetical order of filepaths. That means that comment upload should have weight 1 or we should get rid of the code in #1.

#4

Posted by aharown07 on April 1, 2009 at 3:03pm

I've been directed here because using Quote module doubles the quote text when you click Preview if Comment Upload is enabled.... (#307009: comment_upload having weird behaviour with "quote" module ...) which I'm led to believe has something to do w/this issue here with weight.

What I don't know, though, is what does it have to do with weight, what weight are we talking about, and if there is some setting or code I need to change, where do I go to do that?
Thanks for any guidance.

Edit: Found it. Line 505 in comment_upload.module contains $file->weight = 0;
I changed this to $file->weight = 2; and this fixed the problem at my site.
What impact that might have on other modules I don't know.

#5

Posted by aharown07 on May 16, 2009 at 10:08pm
Version:6.x-1.x-dev» 6.x-1.0-alpha4

I'm having this problem again now and changing weight does not correct it. Ideas?

(When I comment out code in #1, problem goes away... but what's the impact on Comment Upload?)

Edit: I'm not seeing any impact (yet). Files attach just fine... and preview seems to work OK also. What is the code in #1 for?

#6

Posted by aharown07 on May 17, 2009 at 1:40am

OK, I see the impact now. Removing that code basically breaks Preview anytime I don't use Quote.
So I don't have a workaround for this at present... maybe I'll just disable preview on my site.

#7

Posted by aharown07 on May 17, 2009 at 1:41am
Category:task» bug report

#8

Posted by aharown07 on May 17, 2009 at 1:42am
Title:Set weight to ?» Set weight to ? (Preview w/Quote module causes doubled text)

#9

Posted by epedder on October 2, 2009 at 3:21am

I'm having the same problem. I also have advanced_forum installed and the Preview button does not actually display the preview (everything else is in place). As far as I can see the preview template is never used. I've tried changing the weight and removing the code in #1 but none of these steps help.

I have to choose between disabling comment_upload (6.x-1.0-alpha5) and disabling preview. What is the best way to disable the preview button?