Empty block should not have results [#366659]

The views module allows empty blocks to be hidden altogether. Unfortunately that did not work with tagadelic blocks because even if none of the nodes had tags, the nodes would still be listed in $view->result. This keeps the views module from noticing that the block is empty (see http://drupal.org/node/332762). This patch fixes that by clearing the $view->result array when the block is empty.

This patch is for version 6.x-1, but the issue tracker did not allow me to select that version, hence this issue is incorrectly labelled as 5.x-1.x-dev.

Comment	File	Size	Author
#3	theme.inc.patch	801 bytes	anrikun
	tagadelic_views.patch	639 bytes	gustav

Comments

Comment #1

indytechcook commented 1 February 2009 at 14:35

Version:

5.x-1.x-dev

» 6.x-1.x-dev

Good Catch gustav. Has anyone else reviewed this patch?

Comment #2

anrikun commented 5 March 2010 at 18:03

Version:

6.x-1.x-dev

» 6.x-1.1

This patch works but it seems to have been badly committed into 6.x-1.1
From line 49 in theme.inc, instead of:

<?php
    $tags = tagadelic_build_weighted_tags($result, $options['steps']);
    $tags = tagadelic_sort_tags($tags);
    if (!empty($vars['output'])) {
      $view->result= NULL;
    }
    $vars['output'] = theme('tagadelic_weighted', $tags);
?>

It should be:

<?php
    $tags = tagadelic_build_weighted_tags($result, $options['steps']);
    $tags = tagadelic_sort_tags($tags);
    $vars['output'] = theme('tagadelic_weighted', $tags);
    if (empty($vars['output'])) {
      $view->result = NULL;
    }
?>

Because of that, the same bug still occurs in 6.x-1.1.