By penelopehead on

My first drupal powered website, Powerlifting Watch is up and running. Between the core instal and the addon modules, I've been able to build, what I think is a nice and functional website. The one piece I had to build from scratch was the powerlifting meets search function. Although the code is not pretty, it works!

Any feedback would be appreciated.

Jon

Comments

javanaut’s picture

javanaut commented

Nice. However, in Firefox, the text on the poll block is white on a white background. I like the color scheme.

tclineks’s picture

tclineks commented

Hi Jon,

The site looks great except for a small style problem.

.form-item label (line 64)
{
font-size: 1em;
color: rgb(255, 255, 255);
}

and

.block-poll (line 328)
{
border-bottom-width: 2px;
border-bottom-style: solid;
border-bottom-color: rgb(0, 0, 0);
padding-top: 10px;
padding-bottom: 10px;
margin-bottom: 1.5em;
background-color: white;
color: rgb(0, 0, 0);
}

are apparently contradictory and are rendering most text in the poll block as white on a white background (in ff and ie6.0 for me).

Might I suggest the W3C (x)html validator - http://validator.w3.org/check?verbose=1&uri=http%3A//www.powerliftingwat... and it's css validator - http://jigsaw.w3.org/css-validator/validator?profile=css2&warning=2&uri=...

Great work!

tclineks

penelopehead’s picture

penelopehead commented

My FF and IE are rendering text in black, so thanks for the heads up. I'm going to fix that right now.

Jon

penelopehead’s picture

penelopehead commented

I can't replicate the white on white so I wonder if this has eliminated the problem. On the right block I have a white background for the poll with black text. When the poll is in the body it should be a grey background with white text. Here's the style info for the text:

.block-poll .content .poll .text{
color: #000;
}

.main .content .poll .text{
color: #ffffff;
}

Thoughts?

Jon

tclineks’s picture

tclineks commented

I don't see that "text" class anywhere in the output.

this line will give you black text when on the right side.
div.choices div.form-item label { color: #000 }

for white bg and black text when on right side:
#sidebar-right div.block-poll { background: #fff } /* poll container div */
#sidebar-right div.block-poll div.vote-form { background: transparent } /* use parent color */
#sidebar-right div.block-poll div.choices div.form-item label { color: #000 }

for grey bg and white text when in main content :
#main div.block-poll { background: #999 }
#main div.block-poll div.vote-form { background: transparent } /* use parent color */
#main div.block-poll div.choices div.form-item label { color: #fff }

These descriptors are more complex than necessary, fyi.

I checked the site and get white-on-white in ff ie(5.01-6.0) and opera.

penelopehead’s picture

penelopehead commented

Ok I found the white on white. The poll is different for users who are logged in and have voted. Which I was and had done. It looks okay now. I just made the .choices .form-item label{#000;) change. I wonder if I'll get a few more votes. I'm actually surprised I've had as many as I've gotten. Thanks for the extra sets of eyes guys.

Jon