This one's a heck of an edge case, but...

In #364777: Add a "stripped down" CSS theme to core JohnAlbin rolled the patch according to the instructions at http://drupal.org/patch/create, which says to edit CVS/Entries to make note of new files. This works fine for code files, but not for binary files. Because what happens is when php -l tries to test a file that doesn't exist, it bombs out. However, the error returned to the testing bot is a very unhelpful "Invalid PHP syntax." This was especially odd, given that this issue had 0 lines of PHP.

So if it's possible to patch testing bot so it gives a more helpful message that would avoid headaches in the future.

Comments

boombatower’s picture

boombatower commented
Status: Active » Postponed (maintainer needs more info)

Added the file it failed on. #367017: Report back the name of the file that failed php -l

That what your looking for. Not sure I fully understand.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Postponed (maintainer needs more info) » Fixed

That actually might be good enough, thanks!

I made this issue because we spent a good half hour trying to figure out how the lint test was failing with this patch. Had the name of the image been there, we probably would've figured it out in more like 30 seconds. :)

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.