New mapper for Phone field (CCK)

CommentFileSizeAuthor
#1 feedapi_mapper_367205_phone.patch2.39 KBscottrigby

Comments

scottrigby’s picture

scottrigby
he/him
Primary language English
Location Brooklyn, NY
commented
Status: Active » Needs review
StatusFileSize
new feedapi_mapper_367205_phone.patch2.39 KB

Patch attached.

One thing this doesn't do yet is validate the phone number...

Short of that, it seems to work well for me. It respects user configured settings on the phone field (adding country code, parenthesis around area code, & separators).

BTW, I noticed my patches don't add files to the appropriate module subfolders (like /mappers) when patched from the module root. So for now, to test, patch from the /mappers directory :p

alex_b’s picture

alex_b commented
Status: Needs review » Needs work 
$phone_cck_types = array('fr_phone', 'it_phone', 'ca_phone', 'cr_phone', 'uk_phone', 'ru_phone', 'es_phone', 'au_phone', 'cs_phone', 'hu_phone');

Could this be done without assuming a fixed set of supported languages?

alex_b’s picture

alex_b commented
Title: Phone field » Mapper for phone field

I'd rather have this in the phone field module and not in Feed Element Mapper. Will need work for new API (see api.php)

BenK’s picture

BenK commented

Subscribing....