Hey Garrett,

I don't know if this is something that should be done, but I've had to change it so paypal can work with BIN.

I've changed this:

function uc_auction_now_order($op, &$arg1, $arg2) {
if ($op === 'submit') {

to this:

function uc_auction_now_order($op, &$arg1, $arg2) {
if ($op === 'save') {

I found that the BIN auctions weren't ending when people payed by paypal. It seems to work, but this part isn't my forte so I thought I'd let you know and see what your feedback is.

Comments

Garrett Albright’s picture

Garrett Albright commented
Status: Active » Closed (won't fix)

This should *not* be done, because this function checks to see if a user really can buy the items they've added to their cart. For example, if an item is about to expire and someone adds it to their cart using Buy Now, then the auction expires before they complete their order, this function will stop them from completing their order until the item is removed (because the person that won the auction without using Buy Now should be the winner). However, Ubercart will ignore the command to not let the order go through if this function is called with $op === 'save' - it only checks for it when $op === 'submit'. If this function is never being called with $op === 'submit' when PalPal is being used, we need to figure out why, but we can't change that line in this module. (Here's Ubercart's API documentation regarding this function.)

Is it possible that you have to accept the payment from PayPal's web interface first?

andrewoke’s picture

andrewoke commented

I'll check.