Editing issue follow-up comments broken [#367419]

As reported by webernet at #367063-1: Project issue regressions, if you try to edit an existing followup comment on an issue, you get errors:

A) The usual issue metadata fields are gone, but when you try to preview, you get a validation error because it thinks the project and issue title are empty (and it then displays the metadata fields).

B) The comment_alter_taxonomy field is there, whereas on the current D5 site, none of that is present while editing a followup (which is good, since if you want to change the tags, just like any other metadata, you should followup again so there's a history of changes).

C) The comment_upload fieldset is there, which we also don't want (for the same reasons).

Comment	File	Size	Author
#9	pi_comment_edit_fix.patch	821 bytes	hunmonk
#1	pi_edit_comments_fix.patch	2.93 KB	hunmonk

Comments

Comment #1

hunmonk commented 18 February 2009 at 19:49

Status:

Active

» Needs review

Status	File	Size
new	pi_edit_comments_fix.patch	2.93 KB

this patch should fix things, and also fixes the busted breadcrumbs on comment edit pages. probably want to backport a portion of this to 5.x for the breadcrumb part...

the basic problem was that the AHAH fix was pointing the submit buttons to the wrong place on comment edit forms, so i just moved it below the check for an existing comment. the breadcrumbs are fixed by a small new function that tests for the comment edit page, and moving the breadcrumb set function _above_ the test for an existing comment.

Comment #2

dww

we/he/they

commented 18 February 2009 at 19:52

Status:

Needs review

» Reviewed & tested by the community

Works for my local testing and code looks great. Thanks!

Comment #3

dww

we/he/they

commented 19 February 2009 at 07:23

Status:

Reviewed & tested by the community

» Fixed

This was committed and deployed before the site went live.

Comment #4

dww

we/he/they

commented 19 February 2009 at 09:35

Status:

Fixed

» Active

Nope, still broken. If you edit a followup, you now get "You must enter a project to navigate to."

EDIT: this comment was changed.

Comment #8

damien tournoud commented 20 February 2009 at 00:48

B) The comment_alter_taxonomy field is there, whereas on the current D5 site, none of that is present while editing a followup (which is good, since if you want to change the tags, just like any other metadata, you should followup again so there's a history of changes).

This part of the issue was fixed and deployed on #377572: Taxonomy widgets are displayed on comment editing.