I only raise this since this module is still in 'dev' status. It's especially bad in this case as there is a 'filter' module in core. This module name should be 'filtermacros'.

From the book "Pro Drupal Development" page 482:

Module names should never include an underscore. To understand why, think of the following scenario:
1. A developer create node_list.module that contains a function call node_list_all().
2. In the next version of Drupal, the core node module adds a function called node_list_all()--namespace conflict!

Thanks for a very nifty module!

Comments

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented

The problem is not the underscore, but that the module name start with a string that is already used to name a Drupal core module.
To say the true, most Drupal core functions doesn't have a module prefix (see check_plain(), in example); then, even if you would not use underscores in the module name, it's not said you would not use a name for the module that is then used for a Drupal core module.

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Issue summary: View changes
Status: Active » Closed (outdated)

I am closing this issue, which is for a not supported Drupal version.