Provide a top level 'internationalisation' menu item.

catch - February 2, 2009 - 17:59
Project:Drupal
Version:7.x-dev
Component:user interface text
Category:task
Priority:normal
Assigned:Unassigned
Status:closed
Issue tags:Needs Documentation, Screenshot, Usability
Description

In core we have locale.module and translation.module. Contrib has i18n, i10_server and others. I think it makes sense to collate the administrative items for these modules under a single "internationalisation" menu item - this would include the languages settings in site configuration as well (adding a language to a site isn't really a 'setting' IMO).

This would have the advantage of moving interface translation out of site building (it's not really site building), and making these features easily accessible in one place.

I'm also going to open an issue for a development menu item - for simpletest (core), but also devel and schema modules to add themselves to. Again, for much the same reasons.

#1

yoroy - February 7, 2009 - 00:24

Agreed. These admin items can very well be grouped into their own top level admin section:
- The items in core are already a bit misplaced because it is indeed not really site building
- There's quite a family of internationalisation contrib modules available that will be much easier to find with this dedicated admin section.

#2

catch - February 11, 2009 - 17:41
Status:active» needs review

Here's a patch, turns out that translation module doesn't actually define an admin menu item anywhere - just form_alters the content type admin forms. However locale module has two top level items, and the translation settings could arguably not be hidden in workflow settings so maybe move here too.

Need to verify that if two modules define the same router item it'll just overwrite/ignore the second entry rather than break - going to do that with the development item now.

AttachmentSizeStatusTest resultOperations
internationalization.patch4.76 KBIdleFailed: 9520 passes, 130 fails, 13 exceptionsView details | Re-test

#3

catch - February 11, 2009 - 17:58
Status:needs review» needs work

screenshot.

Also, tests not updated yet.

AttachmentSizeStatusTest resultOperations
Screenshot-Administer | d7.7 - Mozilla Firefox-1.png53.88 KBIgnoredNoneNone

#4

Noyz - February 11, 2009 - 21:16

+1

Ultimately I think more work needs to be done. Seems like users should be able to enable multi-language support, and tweak the settings of it's output via the modules settings. I think this is getting closer: http://skitch.com/yoroy/brmpw/localization-client

None-the-less, this is better than what's there today.

#5

Bevan - February 11, 2009 - 21:41

I agree this is an improvement

#6

catch - February 11, 2009 - 22:50
Title:Provide a top level 'internationalisation' menu item.» Provide a top level 'internationalization' menu item.
Status:needs work» needs review

All tests should pass with this one.

AttachmentSizeStatusTest resultOperations
internationalization.patch35.28 KBIdleFailed: 9660 passes, 12 fails, 5 exceptionsView details | Re-test

#7

System Message - February 11, 2009 - 23:10
Status:needs review» needs work

The last submitted patch failed testing.

#8

catch - February 11, 2009 - 23:32
Title:Provide a top level 'internationalization' menu item.» Provide a top level 'internationalisation' menu item.
Status:needs work» needs review

The test I wrote came back to bite me. Updated that one too.

AttachmentSizeStatusTest resultOperations
internationalization..patch0 bytesIdlePassed: 10805 passes, 0 fails, 0 exceptionsView details | Re-test

#9

yoroy - February 12, 2009 - 07:58

Let's try some simpler wording. What is this setting-group's name in your favourite OS? e.g. in OS X it's called 'International'. How about:

International
Languages and translation

#10

catch - February 12, 2009 - 12:38

In Ubuntu I have 'Language settings' and a separate section for date/time. Internationalization makes for a long path, and international sounds better to me.

New, non-empty patch and screenshot.

screenshot

AttachmentSizeStatusTest resultOperations
international.patch44.14 KBIdleFailed: 9725 passes, 8 fails, 0 exceptionsView details | Re-test
international.png34.62 KBIgnoredNoneNone

#11

System Message - February 13, 2009 - 13:35
Status:needs review» needs work

The last submitted patch failed testing.

#12

catch - February 13, 2009 - 16:46
Status:needs work» needs review

Re-rolled for the new locale test, minor whitespace fixes crept into the patch, sorry.

AttachmentSizeStatusTest resultOperations
international.patch40.2 KBIdleFailed: Failed to apply patch.View details | Re-test

#13

System Message - February 24, 2009 - 20:30
Status:needs review» needs work

The last submitted patch failed testing.

#14

Pasqualle - March 9, 2009 - 06:00

I would not create a top level menu item for 2 links..
The i18n and l10n_client modules do not add any new links to that group. The l10n_server module is used on 50 sites and all will be replaced by one translation server on d.o, so that is a bad example..

I would consider the possibility moving the "interface translations" inside "languages" because I many times searched for that inside the Language settings.
Or redesign the whole menu structure for language related menu links, because I am not convinced with the reasoning, this change isn't an improvement yet..

#15

yoroy - March 9, 2009 - 08:27

Yes, all language locale and translation related menu items should move into this section. Contrib modules should update to move their links into this section as well.

#16

Bojhan - March 29, 2009 - 18:25

Sounds like a solid improvement, failed to apply patch - can someone review why?

#17

Berdir - March 29, 2009 - 22:10
Status:needs work» needs review

Re-rolled.

No idea why the patch failed, it were just text (url) replacements, some worked, some not.

AttachmentSizeStatusTest resultOperations
international_1.patch58.16 KBIdleFailed: Failed to apply patch.View details | Re-test

#18

Bojhan - March 30, 2009 - 13:48
Status:needs review» reviewed & tested by the community

Marking this rtbc, I don't see any objections to this patch other then "other things should be under this as well".

#19

webchick - March 31, 2009 - 02:02
Status:reviewed & tested by the community» needs work
Issue tags:+Needs Documentation

Awesome! Committed to HEAD.

This should be reflected in the ugprade docs for other modules that might want to add settings under here.

#20

catch - March 31, 2009 - 11:06
Status:needs work» fixed

documented :)

#21

System Message - April 14, 2009 - 11:10
Status:fixed» closed

Automatically closed -- issue fixed for 2 weeks with no activity.

#22

c960657 - April 21, 2009 - 21:06
Status:closed» needs review

This broke the edit and delete links in the table on admin/international/translate/translate.

AttachmentSizeStatusTest resultOperations
368064-followup-1.patch1.49 KBIdlePassed: 10805 passes, 0 fails, 0 exceptionsView details | Re-test

#23

Dave Reid - April 21, 2009 - 22:17

We probably need some tests then...

#24

pwolanin - April 22, 2009 - 16:04
Status:needs review» reviewed & tested by the community

I tested this patch, and it fixes the bug (just a typo with leading slashes). Really this is not something likely to regress and we generally don't test our clickcable links everywhere in the UI with simpletest.

#25

webchick - April 22, 2009 - 16:07
Status:reviewed & tested by the community» fixed

Committed to HEAD. Thanks!

#26

System Message - May 6, 2009 - 16:10
Status:fixed» closed

Automatically closed -- issue fixed for 2 weeks with no activity.

 
 

Drupal is a registered trademark of Dries Buytaert.