Race condition in notification
jromine - February 2, 2009 - 21:40
| Project: | Notify |
| Version: | 5.x-1.2 |
| Component: | Code |
| Category: | bug report |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | needs review |
Description
Notify looks for nodes created in a time window between the last time
notify was run (notify_send_last), and the current time. After processing
any notifications, notify_send_last is set to the current time.
Bug: nodes created in the time window between when notify begins
executing its query, and the time that notify_send_last is updated,
are missed.
Fix: upon completion, set notify_send_last to be the time notify began
executing, rather than the time it finished.
#1
attaching patch
#2
corrected fix (last part was missing)
#3
This was also reported against notify-6.x-1.0 as #365700: Job Queue integration