Module name extracted

Pasqualle - February 2, 2009 - 22:19
Project:Translation template extractor
Version:6.x-2.x-dev
Component:Code
Category:support request
Priority:normal
Assigned:Unassigned
Status:closed
Description

I would like to know why is the module name extracted? As I know it should not be translated and the translated version is not displayed anywhere.

info.0 - key "name" in the info file
module.0 - module filename

#1

Zoltán Balogh - February 3, 2009 - 11:28

+1 I would like to know too.

#2

Gábor Hojtsy - February 3, 2009 - 12:25

It definitely used to be use before .info files were present (used to be t()-ed in the module listing). The current use or lack of use should be looked into.

#3

Dave Reid - March 18, 2009 - 16:42

I took a look at contributions/translations/drupal-pot/general.pot (DRUPAL-6--1). It appears that the name, description, and package fields are all used in translations. Should this be marked by design?

#4

Gábor Hojtsy - March 18, 2009 - 16:44

This issue is about the module internal name (such as "potx" included in the output), not the .info file name attribute value (such as "Translation template extractor").

#5

Dave Reid - March 18, 2009 - 17:08
Status:active» needs review

Well the original post did mention 'info.0 - key "name" in the info file', but that should be included in the pot files. Attached patch removes the extraction of the module or theme's machine name (e.g. module_name).

AttachmentSize
368197-potx-no-module-machine-name-D6.patch 843 bytes

#6

Pasqualle - March 18, 2009 - 17:11
Status:needs review» active

potx.module:0 = potx
potx.info:0 = Translation template extractor

none of these should be in the export, as they should not be translated. Where is it displayed as translated in Drupal?
I know some modules (like Advanced help) translates the module name, but that's a bug in the module..

#7

Pasqualle - March 18, 2009 - 17:12
Status:active» needs review

crosspost

#8

Dave Reid - March 18, 2009 - 17:16

Isn't "potx.info:0 = Translation template extractor" translated in admin/build/modules? All the official translations for Drupal core have all the module .info name values translated:

es/general.po:
#: modules/update/update.info:0
msgid "Update status"
msgstr "Estado de actualización"

#: modules/trigger/trigger.info:0
msgid "Trigger"
msgstr "Disparador"

etc...

#9

Pasqualle - March 18, 2009 - 17:25

but not displayed

no, the admin/build/modules page does not translate the module names

#10

Pasqualle - March 18, 2009 - 17:24

note: module name = full English name of the project

Module names are essential parts of the d.o infrastructure (now), like you can filter issues by module name. It will not work with translated names..

#11

Dave Reid - March 18, 2009 - 17:34

I just tried working with Spanish as default language on my local install. Imported all the Spanish translations and saw that module names are not translated ever on admin/build/modules, admin/help, or admin/help/module_name. Interesting.

#12

Pasqualle - March 18, 2009 - 17:38

#152375: Implement translatable module names (with context) it is still undecided, but the current situation is that module names are not translated

#13

Dave Reid - March 18, 2009 - 20:13

Got it. We do agree however that the machine name of the module (e.g. my_module) should not be included in the translation file right? If so, please review patch in #5.

#14

Gábor Hojtsy - April 2, 2009 - 11:03
Version:6.x-2.x-dev» 5.x-2.x-dev
Status:needs review» patch (to be ported)

Committed #5 to Drupal 6.x-2.x, thanks. I am not actually actively maintaining the 5.x branches, but moving down so we have an accurate list of stuff not there yet.

#15

Dave Reid - August 22, 2009 - 20:51

Marked #556754: Don't extract module names as a duplicate of this.

#16

Gábor Hojtsy - August 24, 2009 - 13:00
Version:5.x-2.x-dev» 6.x-2.x-dev
Status:patch (to be ported)» fixed

Since 5.x is not maintained, moving back to fixed.

#17

System Message - September 7, 2009 - 13:10
Status:fixed» closed

Automatically closed -- issue fixed for 2 weeks with no activity.

 
 

Drupal is a registered trademark of Dries Buytaert.