I noticed that in the initial commit, there was no mention of the field system in CHANGELOG.txt. I'm going to go out on a limb and say this is an important enough change to Drupal that it should be mentioned there..... :) Maybe this should wait until some of the big issues surrounding the field API are worked out, though.

Congratulations to everyone who worked to get this in, by the way.... I am proud to have been a (very small) part of it!

CommentFileSizeAuthor
#13 368661-13-mechfish.patch900 bytesmike booth
#5 368661-5-mechfish.patch838 bytesmike booth
#3 368661-axyjo-2.patch779 bytesaxyjo

Comments

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Issue tags: +Novice
axyjo’s picture

axyjo commented

Here it is. I hope it's adequate enough.

axyjo’s picture

axyjo commented
StatusFileSize
new 368661-axyjo-2.patch779 bytes

Umm. Attachment got lost, I guess. I attached it, then I hit preview, then I hit post. Can anyone reproduce that?

axyjo’s picture

axyjo commented
Assigned: Unassigned » axyjo
Status: Active » Needs work

I should probably change the issue settings too.

mike booth’s picture

mike booth commented
StatusFileSize
new 368661-5-mechfish.patch838 bytes

I rewrote the text of this patch a bit, borrowing words from http://api.drupal.org/api/group/field/7.

mike booth’s picture

mike booth commented
Status: Needs work » Needs review

Hm, might help to mark this for review...

xmacinfo’s picture

xmacinfo
he/him
Primary language French
Location Canada
commented
Status: Needs review » Reviewed & tested by the community

Verified! It adds an entry in the last portion of the CHANGELOG.txt file for Drupal 7.

Status: Reviewed & tested by the community » Needs work

The last submitted patch failed testing.

xmacinfo’s picture

xmacinfo
he/him
Primary language French
Location Canada
commented

The CHANGELOG.txt file needs a test? Please confirm.

bjaspan’s picture

bjaspan commented

The "tests" failed because the patch did not apply; perhaps the CHANGELOG file changed after the patch was created. The patch needs to be re-rolled. Mike?

mike booth’s picture

mike booth commented

I'm on it, and it's sure to be the easiest reroll ever, but I can't do until tomorrow. CVS isn't working from my hotel. It would appear that the local wireless is blocking everything but port 80.

I'm sure your diagnosis is correct: The test passed yesterday, but one of the commits last night must have broken it.

xmacinfo’s picture

xmacinfo
he/him
Primary language French
Location Canada
commented

Indeed, new additions were made to the changelog for the jQuery updates.

mike booth’s picture

mike booth commented
StatusFileSize
new 368661-13-mechfish.patch900 bytes

Okay, rerolled. And, +1 for the Corner Bakery's free WiFi in the DC train station.

xmacinfo’s picture

xmacinfo
he/him
Primary language French
Location Canada
commented
Status: Needs work » Reviewed & tested by the community

Verified. Please commit.

dries’s picture

dries commented
Status: Reviewed & tested by the community » Fixed

Committed to CVS HEAD. Thanks!

Status: Fixed » Closed (fixed)
Issue tags: -Novice

Automatically closed -- issue fixed for 2 weeks with no activity.

Issue tags: +Novice

Restoring issue tags, see #2125755: System messages removed all issue tags during D7 upgrade.