Accept style property names in uppercase
davexoxide - February 3, 2009 - 19:50
| Project: | WYSIWYG Filter |
| Version: | 6.x-1.1 |
| Component: | Code |
| Category: | bug report |
| Priority: | normal |
| Assigned: | davexoxide |
| Status: | closed |
Jump to:
Description
Was having troubles with YUI RTE in IE6 and IE7. Where background-color and color would not display properly. Appears that WYSIWYG editor does not agree COLOR = color or BACKGROUND-COLOR = background-color.
Added this very simple change and now everything works as expected.
| Attachment | Size |
|---|---|
| wysiwyg_IE_lower.diff | 343 bytes |
#1
hmm... your patch would also affect style property values, which could lead to unexpected results, for example when URLs for background images are involved, etc.
I'm commiting to CVS the following instead:
<?php// Ignore properties that do not match the format "property-name: value".
continue;
}
- $property_name = &$property_matches[1];
+ $property_name = strtolower($property_matches[1]);
$property_value = &$property_matches[2];
if (!isset($allowed_properties[$property_name])) {
// Ignore property if not whitelisted in filter settings.
?>
Please, let me know if this works for you as well. Thanks.
#2
#3
Better name.